From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPjgP-00072u-PP for qemu-devel@nongnu.org; Thu, 26 May 2011 19:09:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QPjgO-0007RI-PO for qemu-devel@nongnu.org; Thu, 26 May 2011 19:09:37 -0400 Received: from mail.hq.newdream.net ([66.33.206.127]:47283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPjgO-0007Qz-FP for qemu-devel@nongnu.org; Thu, 26 May 2011 19:09:36 -0400 Message-ID: <4DDEDDB0.3010501@dreamhost.com> Date: Thu, 26 May 2011 16:09:36 -0700 From: Josh Durgin MIME-Version: 1.0 References: <1306355687-4647-1-git-send-email-josh.durgin@dreamhost.com> <1306355687-4647-5-git-send-email-josh.durgin@dreamhost.com> <4DDE09D4.6020705@redhat.com> In-Reply-To: <4DDE09D4.6020705@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 4/4] rbd: Add bdrv_truncate implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: ceph-devel@vger.kernel.org, qemu-devel@nongnu.org, kvm@vger.kernel.org, Christian Brunner On 05/26/2011 01:05 AM, Kevin Wolf wrote: > Am 25.05.2011 22:34, schrieb Josh Durgin: >> Signed-off-by: Josh Durgin >> --- >> block/rbd.c | 15 +++++++++++++++ >> 1 files changed, 15 insertions(+), 0 deletions(-) >> >> diff --git a/block/rbd.c b/block/rbd.c >> index a44d160..b95b1eb 100644 >> --- a/block/rbd.c >> +++ b/block/rbd.c >> @@ -688,6 +688,20 @@ static int64_t qemu_rbd_getlength(BlockDriverState *bs) >> return info.size; >> } >> >> +static int qemu_rbd_truncate(BlockDriverState *bs, int64_t offset) >> +{ >> + BDRVRBDState *s = bs->opaque; >> + int r; >> + >> + r = rbd_resize(s->image, offset); >> + if (r< 0) { >> + error_report("failed to resize rbd image"); >> + return -EIO; >> + } > > Don't print an error message here. The caller will do it, too, so we end > up with two error messages saying the same. Fixed. > What kind of error code does rbd_resize return? If it is a valid errno > value, you should return r instead of turning it into EIO. > > Kevin The error code is a standard errno value. Josh