From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPp8k-0000su-MQ for qemu-devel@nongnu.org; Fri, 27 May 2011 00:59:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QPp8j-0005nc-Kt for qemu-devel@nongnu.org; Fri, 27 May 2011 00:59:14 -0400 Received: from moutng.kundenserver.de ([212.227.17.10]:58145) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPp8j-0005nS-9f for qemu-devel@nongnu.org; Fri, 27 May 2011 00:59:13 -0400 Message-ID: <4DDF2F9D.4040208@mail.berlios.de> Date: Fri, 27 May 2011 06:59:09 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1306355129-23447-1-git-send-email-weil@mail.berlios.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 00/12] target-s390x: Several small fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: Peter Maydell , Alexander Graf , QEMU Developers Am 26.05.2011 23:48, schrieb Andreas Färber: > Am 26.05.2011 um 00:17 schrieb Alexander Graf: > >> On 26.05.2011, at 00:10, Peter Maydell wrote: >> >>> On 25 May 2011 21:25, Stefan Weil wrote: >>>> Feel free to combine patches if larger patches are preferred. >>> >>> I'd vote for combining at least 03..12, having nine patches all >>> of which have the same summary line is a bit confusing :-) >> >> I actually like them as individual patches. Makes bisecting a lot >> easier :). > > Stefan, could you add the function name or some other discriminator to > the subject then, please? > > Andreas This would result in these subjects: 4 x target-s390x: Add missing tcg_temp_free_i64() in disas_a5 2 x target-s390x: Add missing tcg_temp_free_i64() in disas_s390_insn 1 x target-s390x: Add missing tcg_temp_free_i64() in disas_b2 1 x target-s390x: Add missing tcg_temp_free_i64() in do_mh 1 x target-s390x: Add missing tcg_temp_free_i64() in gen_jcc So there remain duplicate subjects. Adding the line number or a sequence number would look somehow strange. The subjects are identical simply because the changes are very similar. If needed, git provides the unique identification. Maybe combining the patches which share the same function and add this function name to the subject would be a compromise which still allows bisecting. Cheers, Stefan