From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46586)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QPrDX-0004kO-D6
	for qemu-devel@nongnu.org; Fri, 27 May 2011 03:12:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QPrDW-00004w-Li
	for qemu-devel@nongnu.org; Fri, 27 May 2011 03:12:19 -0400
Received: from mail-ww0-f41.google.com ([74.125.82.41]:37214)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QPrDW-00004r-Fw
	for qemu-devel@nongnu.org; Fri, 27 May 2011 03:12:18 -0400
Received: by wwi18 with SMTP id 18so5132050wwi.4
	for <qemu-devel@nongnu.org>; Fri, 27 May 2011 00:12:17 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4DDF4ECF.5060406@redhat.com>
Date: Fri, 27 May 2011 09:12:15 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <4DDEA34C.4040304@linux.vnet.ibm.com>
In-Reply-To: <4DDEA34C.4040304@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] host-pcc: enable building with -m32 or -m64
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: agraf@suse.de, qemu-devel@nongnu.org

On 05/26/2011 09:00 PM, Stefan Berger wrote:
> With the below patch I can build either ppc (-m32) or ppc64 (-m64)
> versions of Qemu (on a ppc64 host) when passing these compiler flags via
> 'configure ... --extra-cflags="-m32"'.
>
> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
>
> ---
> configure | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> Index: qemu-git/configure
> ===================================================================
> --- qemu-git.orig/configure
> +++ qemu-git/configure
> @@ -807,7 +807,14 @@ case "$cpu" in
> arm*)
> host_guest_base="yes"
> ;;
> - ppc*)
> + ppc)
> + QEMU_CFLAGS="-m32 $QEMU_CFLAGS"
> + LDFLAGS="-m32 $LDFLAGS"
> + host_guest_base="yes"
> + ;;
> + ppc64)
> + QEMU_CFLAGS="-m64 $QEMU_CFLAGS"
> + LDFLAGS="-m64 $LDFLAGS"
> host_guest_base="yes"
> ;;
> mips*)

The patch doesn't seem to match the description.  I would have guessed 
that with this patch you _do not_ need to pass these compiler flags via 
--extra-cflags anymore.

Also, -m32/-m64 are really CPPFLAGS, not CFLAGS since they affect also 
the compiler's include path.

Paolo