From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPx8i-0000dM-2p for qemu-devel@nongnu.org; Fri, 27 May 2011 09:31:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QPx8g-00031I-PH for qemu-devel@nongnu.org; Fri, 27 May 2011 09:31:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35376) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPx8g-00030X-IP for qemu-devel@nongnu.org; Fri, 27 May 2011 09:31:42 -0400 Message-ID: <4DDFA7AD.50809@redhat.com> Date: Fri, 27 May 2011 15:31:25 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1305903817-25476-1-git-send-email-pbonzini@redhat.com> <1305903817-25476-4-git-send-email-pbonzini@redhat.com> <20110525131049.GB2283@lst.de> <4DDD1E5B.4010900@redhat.com> <20110527130423.GA20998@lst.de> In-Reply-To: <20110527130423.GA20998@lst.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 3/6] scsi-generic: allow customization of the lun List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org On 05/27/2011 03:04 PM, Christoph Hellwig wrote: > Requiring this code in the scsi drivers is a really bad idea. Not only > does it mean duplicating the implementation of REPORT LUNS and the illegal > LUN version of INQUIRY in every scsi LUN handler and the target driver, > but also an inconsitent topology of the qemu-internal objects representing > the SCSI implementation, which is a pretty clear path to all kinds of nast > bugs only showing up for the legacy case some time down the road. > > The right way to solve this is to make sure we always have the proper > target object by creating it under the hood for the legacy case. I know, but this requires changes to the basic qdev layer so I planned to do this later. Also because for bisectability, to avoid dropping a huge patch, I first need to work around the legacy cases and then kill them. Paolo