From: Kevin Wolf <kwolf@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Jes.Sorensen@redhat.com, dlaor@redhat.com, qemu-devel@nongnu.org,
avi@redhat.com
Subject: Re: [Qemu-devel] [patch 1/7] add migration_active function
Date: Fri, 27 May 2011 19:43:06 +0200 [thread overview]
Message-ID: <4DDFE2AA.6070800@redhat.com> (raw)
In-Reply-To: <20110523213410.673809978@amt.cnet>
Am 23.05.2011 23:31, schrieb Marcelo Tosatti:
> To query whether migration is active.
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> Index: qemu-block-copy/migration.c
> ===================================================================
> --- qemu-block-copy.orig/migration.c
> +++ qemu-block-copy/migration.c
> @@ -480,3 +480,13 @@ int get_migration_state(void)
> return MIG_STATE_ERROR;
> }
> }
> +
> +bool migration_active(void)
> +{
> + if (current_migration &&
> + current_migration->get_status(current_migration) == MIG_STATE_ACTIVE) {
> + return true;
> + }
> +
> + return false;
> +}
The very same check already exists open-coded in do_migrate(). Maybe we
should convert it now that a function is available for it?
Kevin
next prev parent reply other threads:[~2011-05-27 17:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 21:31 [Qemu-devel] [patch 0/7] live block copy (v3) Marcelo Tosatti
2011-05-23 21:31 ` [Qemu-devel] [patch 1/7] add migration_active function Marcelo Tosatti
2011-05-27 17:43 ` Kevin Wolf [this message]
2011-05-30 0:53 ` Jes Sorensen
2011-05-23 21:31 ` [Qemu-devel] [patch 2/7] Add blkmirror block driver Marcelo Tosatti
2011-05-24 19:03 ` Blue Swirl
2011-05-27 17:45 ` Kevin Wolf
2011-05-29 8:45 ` Avi Kivity
2011-05-23 21:31 ` [Qemu-devel] [patch 3/7] Add error messages for live block copy Marcelo Tosatti
2011-05-23 21:31 ` [Qemu-devel] [patch 4/7] Add blkdebug points " Marcelo Tosatti
2011-05-23 21:31 ` [Qemu-devel] [patch 5/7] Add vmstop code " Marcelo Tosatti
2011-05-23 21:31 ` [Qemu-devel] [patch 6/7] QEMU " Marcelo Tosatti
2011-05-24 19:15 ` Blue Swirl
2011-06-03 15:59 ` Marcelo Tosatti
2011-05-29 8:54 ` Avi Kivity
2011-05-31 16:06 ` Marcelo Tosatti
2011-05-31 16:14 ` Avi Kivity
2011-05-31 16:38 ` Marcelo Tosatti
2011-05-31 16:53 ` Avi Kivity
2011-06-03 16:20 ` Marcelo Tosatti
2011-05-23 21:31 ` [Qemu-devel] [patch 7/7] do not allow migration if block copy in progress Marcelo Tosatti
2011-05-29 8:54 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2011-06-06 16:55 [Qemu-devel] [patch 0/7] live block copy (v4) Marcelo Tosatti
2011-06-06 16:55 ` [Qemu-devel] [patch 1/7] add migration_active function Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDFE2AA.6070800@redhat.com \
--to=kwolf@redhat.com \
--cc=Jes.Sorensen@redhat.com \
--cc=avi@redhat.com \
--cc=dlaor@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).