From: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: blauwirbel@gmail.com, QEMU Developers <qemu-devel@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v3] virtio-9p: Use relative includes for files in hw
Date: Sat, 28 May 2011 12:12:53 -0700 [thread overview]
Message-ID: <4DE14935.6080009@linux.vnet.ibm.com> (raw)
In-Reply-To: <87d3j2rcny.fsf@linux.vnet.ibm.com>
On 05/28/2011 09:51 AM, Aneesh Kumar K.V wrote:
> On Fri, 27 May 2011 20:27:11 +0200, Stefan Weil<weil@mail.berlios.de> wrote:
>> Am 29.04.2011 02:46, schrieb Peter Maydell:
>>> On 28 April 2011 21:49, Anthony Liguori<anthony@codemonkey.ws> wrote:
>>>
>>>> On 04/28/2011 03:02 PM, Stefan Weil wrote:
>>>>
>>>>> -$(addprefix 9pfs/, $(9pfs-nested-y)): CFLAGS += -I$(SRC_PATH)/hw/
>>>>>
>>>> Wouldn't it be more straight forward to just do QEMU_CFLAGS +=?
>>>>
>>> There aren't any other source files in QEMU which have custom
>>> include paths -- why should 9pfs be a special case?
>>>
>>> -- PMM
>>>
>> Was this an acked-by?
>> The patch is still uncommitted. Are there any objections?
> I have pulled this patch into the tree. I guess the next pull request
> from JV should include that.
Yes, next pull will include this. Thanks.
- JV
> -aneesh
next prev parent reply other threads:[~2011-05-28 19:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 17:08 [Qemu-devel] [PATCH] virtio-9p: Fix compilation (wrong include statements) Stefan Weil
2011-04-28 17:39 ` Anthony Liguori
2011-04-28 17:44 ` Stefan Weil
2011-04-28 17:46 ` Anthony Liguori
2011-04-28 19:04 ` Blue Swirl
2011-04-28 20:02 ` [Qemu-devel] [PATCH v3] virtio-9p: Use relative includes for files in hw Stefan Weil
2011-04-28 20:49 ` Anthony Liguori
2011-04-28 21:44 ` Stefan Weil
2011-04-29 0:46 ` Peter Maydell
2011-05-27 18:27 ` Stefan Weil
2011-05-28 16:51 ` Aneesh Kumar K.V
2011-05-28 19:12 ` Venkateswararao Jujjuri [this message]
2011-04-28 18:21 ` [Qemu-devel] [PATCH v2] " Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE14935.6080009@linux.vnet.ibm.com \
--to=jvrao@linux.vnet.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).