From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQOwb-0000zj-8q for qemu-devel@nongnu.org; Sat, 28 May 2011 15:13:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QQOwa-0008EU-7X for qemu-devel@nongnu.org; Sat, 28 May 2011 15:13:05 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:47947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQOwa-0008EG-1x for qemu-devel@nongnu.org; Sat, 28 May 2011 15:13:04 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e38.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p4SJ4mTn019891 for ; Sat, 28 May 2011 13:04:48 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id p4SJCvZw158484 for ; Sat, 28 May 2011 13:12:57 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p4SDCT31022310 for ; Sat, 28 May 2011 07:12:30 -0600 Message-ID: <4DE14935.6080009@linux.vnet.ibm.com> Date: Sat, 28 May 2011 12:12:53 -0700 From: Venkateswararao Jujjuri MIME-Version: 1.0 References: <1304020934-26995-1-git-send-email-weil@mail.berlios.de> <4DB9D2DC.3080201@codemonkey.ws> <4DDFECFF.4030306@mail.berlios.de> <87d3j2rcny.fsf@linux.vnet.ibm.com> In-Reply-To: <87d3j2rcny.fsf@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] virtio-9p: Use relative includes for files in hw List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" Cc: blauwirbel@gmail.com, QEMU Developers , Peter Maydell On 05/28/2011 09:51 AM, Aneesh Kumar K.V wrote: > On Fri, 27 May 2011 20:27:11 +0200, Stefan Weil wrote: >> Am 29.04.2011 02:46, schrieb Peter Maydell: >>> On 28 April 2011 21:49, Anthony Liguori wrote: >>> >>>> On 04/28/2011 03:02 PM, Stefan Weil wrote: >>>> >>>>> -$(addprefix 9pfs/, $(9pfs-nested-y)): CFLAGS += -I$(SRC_PATH)/hw/ >>>>> >>>> Wouldn't it be more straight forward to just do QEMU_CFLAGS +=? >>>> >>> There aren't any other source files in QEMU which have custom >>> include paths -- why should 9pfs be a special case? >>> >>> -- PMM >>> >> Was this an acked-by? >> The patch is still uncommitted. Are there any objections? > I have pulled this patch into the tree. I guess the next pull request > from JV should include that. Yes, next pull will include this. Thanks. - JV > -aneesh