From: Avi Kivity <avi@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] #include cleanliness
Date: Sun, 29 May 2011 19:30:16 +0300 [thread overview]
Message-ID: <4DE27498.8030109@redhat.com> (raw)
In-Reply-To: <1305814662-16184-1-git-send-email-avi@redhat.com>
On 05/19/2011 05:17 PM, Avi Kivity wrote:
> My mother always told me to explicitly #include any headers need to compile
> a file, instead of relying on other #includes to bring them in. This patch
> fixes up targphys.h and cpu-common.h in this regard.
Can some qemu maintainer review this patch? Stefan?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-05-29 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 14:17 [Qemu-devel] [PATCH] #include cleanliness Avi Kivity
2011-05-29 16:30 ` Avi Kivity [this message]
2011-05-29 22:06 ` Anthony Liguori
2011-05-30 9:06 ` Avi Kivity
2011-05-31 13:43 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE27498.8030109@redhat.com \
--to=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).