From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQisu-00082S-5W for qemu-devel@nongnu.org; Sun, 29 May 2011 12:30:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QQist-0007lV-Bp for qemu-devel@nongnu.org; Sun, 29 May 2011 12:30:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33199) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQist-0007lL-5A for qemu-devel@nongnu.org; Sun, 29 May 2011 12:30:35 -0400 Message-ID: <4DE27498.8030109@redhat.com> Date: Sun, 29 May 2011 19:30:16 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1305814662-16184-1-git-send-email-avi@redhat.com> In-Reply-To: <1305814662-16184-1-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] #include cleanliness List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi On 05/19/2011 05:17 PM, Avi Kivity wrote: > My mother always told me to explicitly #include any headers need to compile > a file, instead of relying on other #includes to bring them in. This patch > fixes up targphys.h and cpu-common.h in this regard. Can some qemu maintainer review this patch? Stefan? -- error compiling committee.c: too many arguments to function