From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQy4I-0005Fv-Mp for qemu-devel@nongnu.org; Mon, 30 May 2011 04:43:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QQy4H-0006XM-99 for qemu-devel@nongnu.org; Mon, 30 May 2011 04:43:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQy4H-0006SR-1n for qemu-devel@nongnu.org; Mon, 30 May 2011 04:43:21 -0400 Message-ID: <4DE3594F.20406@redhat.com> Date: Mon, 30 May 2011 10:46:07 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1306524712-13050-1-git-send-email-lcapitulino@redhat.com> <1306524712-13050-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1306524712-13050-3-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] QMP: Add BLOCK_MEDIA_EJECT event documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: amit.shah@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, armbru@redhat.com Am 27.05.2011 21:31, schrieb Luiz Capitulino: > Signed-off-by: Luiz Capitulino > --- > QMP/qmp-events.txt | 18 ++++++++++++++++++ > 1 files changed, 18 insertions(+), 0 deletions(-) > > diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt > index 0ce5d4e..d53c129 100644 > --- a/QMP/qmp-events.txt > +++ b/QMP/qmp-events.txt > @@ -1,6 +1,24 @@ > QEMU Monitor Protocol Events > ============================ > > +BLOCK_MEDIA_EJECT > +----------------- > + > +Emitted when a removable disk media (such as a CDROM or floppy) is ejected. > + > +Data: > + > +- "device": device name (json-string) > + > +Example: > + > +{ "event": "BLOCK_MEDIA_EJECT", > + "data": { "device": "ide1-cd0" }, > + "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } > + > +NOTE: A disk media can be ejected by the guest or by monitor commands (such > +as "eject" and "change") The monitor command 'eject' already caused a lot of confusion, please don't make the same mistake in this event name. Even though I know more or less what eject can mean in qemu, I'm not sure what "eject" means for you in the context of this event. The 'eject' monitor command means that the image is closed and the BlockDriverState doesn't point to any image file any more. And then there's bdrv_eject(), which is what the guest can do, and it's about the virtual tray status. Having a single event for both doesn't make sense because they are fundamentally different. Something like BLOCKDEV_CLOSE would be the right name for the 'eject' monitor command and maybe something like BLOCKDEV_TRAY_STATUS for the other one. Kevin