From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51672)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QQyQO-0002cG-3o
	for qemu-devel@nongnu.org; Mon, 30 May 2011 05:06:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QQyQN-0001Zb-4o
	for qemu-devel@nongnu.org; Mon, 30 May 2011 05:06:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28167)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QQyQM-0001ZP-Tw
	for qemu-devel@nongnu.org; Mon, 30 May 2011 05:06:11 -0400
Message-ID: <4DE35DFD.600@redhat.com>
Date: Mon, 30 May 2011 12:06:05 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1305814662-16184-1-git-send-email-avi@redhat.com>
	<4DE2C364.6060601@codemonkey.ws>
In-Reply-To: <4DE2C364.6060601@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH]  #include cleanliness
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On 05/30/2011 01:06 AM, Anthony Liguori wrote:
> On 05/19/2011 09:17 AM, Avi Kivity wrote:
>> My mother always told me to explicitly #include any headers need to 
>> compile
>> a file, instead of relying on other #includes to bring them in.  This 
>> patch
>> fixes up targphys.h and cpu-common.h in this regard.
>>
>> Signed-off-by: Avi Kivity<avi@redhat.com>
>> ---
>>   cpu-common.h |    4 ++++
>>   targphys.h   |    2 ++
>>   2 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/cpu-common.h b/cpu-common.h
>> index 151c32c..2009adc 100644
>> --- a/cpu-common.h
>> +++ b/cpu-common.h
>> @@ -18,6 +18,10 @@
>>   #include "bswap.h"
>>   #include "qemu-queue.h"
>>
>> +#include "qemu-common.h"
>> +
>> +#include<stdbool.h>
>
> qemu-common.h should include stdbool.
>
> The idea behind qemu-common.h is to avoid direct includes to help with 
> portability.

Okay.  But note qemu-common.h #includes cpu.h #includes qemu-common.h...

I think osdep.h matches the "help with portability" label better, no?

-- 
error compiling committee.c: too many arguments to function