From: Brad <brad@comstyle.com>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] Use the correct header in the TCG MIPS code to find cacheflush() on OpenBSD.
Date: Mon, 30 May 2011 17:22:06 -0400 [thread overview]
Message-ID: <4DE40A7E.2070000@comstyle.com> (raw)
In-Reply-To: <C7F8BD02-4D9F-4A25-834D-EDB0C50C4DE5@web.de>
On 30/05/11 5:16 PM, Andreas Färber wrote:
> Am 30.05.2011 um 23:01 schrieb Brad:
>
>> On 25/05/11 11:06 PM, Brad wrote:
>>> Use the correct header in the TCG MIPS code to find cacheflush() on
>>> OpenBSD
>>> to fix compilation of the MIPS host support for OpenBSD/mips64 based
>>> architecures.
>>
>> ping.
>>
>>> Signed-off-by: Brad Smith<brad@comstyle.com>
>>>
>>> ---
>>> tcg/mips/tcg-target.h | 4 ++++
>>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/tcg/mips/tcg-target.h b/tcg/mips/tcg-target.h
>>> index 0028bfa..8cb7d88 100644
>>> --- a/tcg/mips/tcg-target.h
>>> +++ b/tcg/mips/tcg-target.h
>>> @@ -102,7 +102,11 @@ enum {
>>> /* guest base is supported */
>>> #define TCG_TARGET_HAS_GUEST_BASE
>>>
>>> +#ifdef __OpenBSD__
>>> +#include<machine/sysarch.h>
>
> Usually we have a space in there. Bad example below. ;)
In the original diff as it came across the mailing list even there
is a space.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
next prev parent reply other threads:[~2011-05-30 21:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 3:06 [Qemu-devel] [PATCH 2/3] Use the correct header in the TCG MIPS code to find cacheflush() on OpenBSD Brad
2011-05-30 21:01 ` Brad
2011-05-30 21:16 ` Andreas Färber
2011-05-30 21:22 ` Brad [this message]
2011-05-30 21:24 ` Brad
2011-05-30 21:41 ` Andreas Färber
2011-06-03 16:24 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE40A7E.2070000@comstyle.com \
--to=brad@comstyle.com \
--cc=andreas.faerber@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).