* [Qemu-devel] [PATCH 2/3] Use the correct header in the TCG MIPS code to find cacheflush() on OpenBSD.
@ 2011-05-26 3:06 Brad
2011-05-30 21:01 ` Brad
2011-06-03 16:24 ` Aurelien Jarno
0 siblings, 2 replies; 7+ messages in thread
From: Brad @ 2011-05-26 3:06 UTC (permalink / raw)
To: qemu-devel
Use the correct header in the TCG MIPS code to find cacheflush() on OpenBSD
to fix compilation of the MIPS host support for OpenBSD/mips64 based architecures.
Signed-off-by: Brad Smith <brad@comstyle.com>
---
tcg/mips/tcg-target.h | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/tcg/mips/tcg-target.h b/tcg/mips/tcg-target.h
index 0028bfa..8cb7d88 100644
--- a/tcg/mips/tcg-target.h
+++ b/tcg/mips/tcg-target.h
@@ -102,7 +102,11 @@ enum {
/* guest base is supported */
#define TCG_TARGET_HAS_GUEST_BASE
+#ifdef __OpenBSD__
+#include <machine/sysarch.h>
+#else
#include <sys/cachectl.h>
+#endif
static inline void flush_icache_range(unsigned long start, unsigned long stop)
{
--
1.7.5
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 2/3] Use the correct header in the TCG MIPS code to find cacheflush() on OpenBSD.
2011-05-26 3:06 [Qemu-devel] [PATCH 2/3] Use the correct header in the TCG MIPS code to find cacheflush() on OpenBSD Brad
@ 2011-05-30 21:01 ` Brad
2011-05-30 21:16 ` Andreas Färber
2011-06-03 16:24 ` Aurelien Jarno
1 sibling, 1 reply; 7+ messages in thread
From: Brad @ 2011-05-30 21:01 UTC (permalink / raw)
To: qemu-devel
On 25/05/11 11:06 PM, Brad wrote:
> Use the correct header in the TCG MIPS code to find cacheflush() on OpenBSD
> to fix compilation of the MIPS host support for OpenBSD/mips64 based architecures.
ping.
> Signed-off-by: Brad Smith<brad@comstyle.com>
>
> ---
> tcg/mips/tcg-target.h | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/tcg/mips/tcg-target.h b/tcg/mips/tcg-target.h
> index 0028bfa..8cb7d88 100644
> --- a/tcg/mips/tcg-target.h
> +++ b/tcg/mips/tcg-target.h
> @@ -102,7 +102,11 @@ enum {
> /* guest base is supported */
> #define TCG_TARGET_HAS_GUEST_BASE
>
> +#ifdef __OpenBSD__
> +#include<machine/sysarch.h>
> +#else
> #include<sys/cachectl.h>
> +#endif
>
> static inline void flush_icache_range(unsigned long start, unsigned long stop)
> {
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 2/3] Use the correct header in the TCG MIPS code to find cacheflush() on OpenBSD.
2011-05-30 21:01 ` Brad
@ 2011-05-30 21:16 ` Andreas Färber
2011-05-30 21:22 ` Brad
0 siblings, 1 reply; 7+ messages in thread
From: Andreas Färber @ 2011-05-30 21:16 UTC (permalink / raw)
To: Brad; +Cc: qemu-devel
Am 30.05.2011 um 23:01 schrieb Brad:
> On 25/05/11 11:06 PM, Brad wrote:
>> Use the correct header in the TCG MIPS code to find cacheflush() on
>> OpenBSD
>> to fix compilation of the MIPS host support for OpenBSD/mips64
>> based architecures.
>
> ping.
>
>> Signed-off-by: Brad Smith<brad@comstyle.com>
>>
>> ---
>> tcg/mips/tcg-target.h | 4 ++++
>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/tcg/mips/tcg-target.h b/tcg/mips/tcg-target.h
>> index 0028bfa..8cb7d88 100644
>> --- a/tcg/mips/tcg-target.h
>> +++ b/tcg/mips/tcg-target.h
>> @@ -102,7 +102,11 @@ enum {
>> /* guest base is supported */
>> #define TCG_TARGET_HAS_GUEST_BASE
>>
>> +#ifdef __OpenBSD__
>> +#include<machine/sysarch.h>
Usually we have a space in there. Bad example below. ;)
>> +#else
>> #include<sys/cachectl.h>
>> +#endif
>>
>> static inline void flush_icache_range(unsigned long start,
>> unsigned long stop)
>> {
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 2/3] Use the correct header in the TCG MIPS code to find cacheflush() on OpenBSD.
2011-05-30 21:16 ` Andreas Färber
@ 2011-05-30 21:22 ` Brad
2011-05-30 21:24 ` Brad
2011-05-30 21:41 ` Andreas Färber
0 siblings, 2 replies; 7+ messages in thread
From: Brad @ 2011-05-30 21:22 UTC (permalink / raw)
To: Andreas Färber; +Cc: qemu-devel
On 30/05/11 5:16 PM, Andreas Färber wrote:
> Am 30.05.2011 um 23:01 schrieb Brad:
>
>> On 25/05/11 11:06 PM, Brad wrote:
>>> Use the correct header in the TCG MIPS code to find cacheflush() on
>>> OpenBSD
>>> to fix compilation of the MIPS host support for OpenBSD/mips64 based
>>> architecures.
>>
>> ping.
>>
>>> Signed-off-by: Brad Smith<brad@comstyle.com>
>>>
>>> ---
>>> tcg/mips/tcg-target.h | 4 ++++
>>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/tcg/mips/tcg-target.h b/tcg/mips/tcg-target.h
>>> index 0028bfa..8cb7d88 100644
>>> --- a/tcg/mips/tcg-target.h
>>> +++ b/tcg/mips/tcg-target.h
>>> @@ -102,7 +102,11 @@ enum {
>>> /* guest base is supported */
>>> #define TCG_TARGET_HAS_GUEST_BASE
>>>
>>> +#ifdef __OpenBSD__
>>> +#include<machine/sysarch.h>
>
> Usually we have a space in there. Bad example below. ;)
In the original diff as it came across the mailing list even there
is a space.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 2/3] Use the correct header in the TCG MIPS code to find cacheflush() on OpenBSD.
2011-05-30 21:22 ` Brad
@ 2011-05-30 21:24 ` Brad
2011-05-30 21:41 ` Andreas Färber
1 sibling, 0 replies; 7+ messages in thread
From: Brad @ 2011-05-30 21:24 UTC (permalink / raw)
To: Andreas Färber; +Cc: qemu-devel
On 30/05/11 5:22 PM, Brad wrote:
> On 30/05/11 5:16 PM, Andreas Färber wrote:
>> Am 30.05.2011 um 23:01 schrieb Brad:
>>
>>> On 25/05/11 11:06 PM, Brad wrote:
>>>> Use the correct header in the TCG MIPS code to find cacheflush() on
>>>> OpenBSD
>>>> to fix compilation of the MIPS host support for OpenBSD/mips64 based
>>>> architecures.
>>>
>>> ping.
>>>
>>>> Signed-off-by: Brad Smith<brad@comstyle.com>
>>>>
>>>> ---
>>>> tcg/mips/tcg-target.h | 4 ++++
>>>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/tcg/mips/tcg-target.h b/tcg/mips/tcg-target.h
>>>> index 0028bfa..8cb7d88 100644
>>>> --- a/tcg/mips/tcg-target.h
>>>> +++ b/tcg/mips/tcg-target.h
>>>> @@ -102,7 +102,11 @@ enum {
>>>> /* guest base is supported */
>>>> #define TCG_TARGET_HAS_GUEST_BASE
>>>>
>>>> +#ifdef __OpenBSD__
>>>> +#include<machine/sysarch.h>
>>
>> Usually we have a space in there. Bad example below. ;)
>
> In the original diff as it came across the mailing list even there
> is a space.
Looks like a case of stupid ThunderBird mangling the e-mail content upon
replying. I didn't send the diff with ThunderBird.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 2/3] Use the correct header in the TCG MIPS code to find cacheflush() on OpenBSD.
2011-05-30 21:22 ` Brad
2011-05-30 21:24 ` Brad
@ 2011-05-30 21:41 ` Andreas Färber
1 sibling, 0 replies; 7+ messages in thread
From: Andreas Färber @ 2011-05-30 21:41 UTC (permalink / raw)
To: Brad; +Cc: qemu-devel
Am 30.05.2011 um 23:22 schrieb Brad:
> On 30/05/11 5:16 PM, Andreas Färber wrote:
>> Am 30.05.2011 um 23:01 schrieb Brad:
>>
>>> On 25/05/11 11:06 PM, Brad wrote:
>>>> Use the correct header in the TCG MIPS code to find cacheflush() on
>>>> OpenBSD
>>>> to fix compilation of the MIPS host support for OpenBSD/mips64
>>>> based
>>>> architecures.
>>>
>>> ping.
>>>
>>>> Signed-off-by: Brad Smith<brad@comstyle.com>
>>>>
>>>> ---
>>>> tcg/mips/tcg-target.h | 4 ++++
>>>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/tcg/mips/tcg-target.h b/tcg/mips/tcg-target.h
>>>> index 0028bfa..8cb7d88 100644
>>>> --- a/tcg/mips/tcg-target.h
>>>> +++ b/tcg/mips/tcg-target.h
>>>> @@ -102,7 +102,11 @@ enum {
>>>> /* guest base is supported */
>>>> #define TCG_TARGET_HAS_GUEST_BASE
>>>>
>>>> +#ifdef __OpenBSD__
>>>> +#include<machine/sysarch.h>
>>
>> Usually we have a space in there. Bad example below. ;)
>
> In the original diff as it came across the mailing list even there
> is a space.
Confirmed, looks better on Patchwork: http://patchwork.ozlabs.org/patch/97488/
Andreas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 2/3] Use the correct header in the TCG MIPS code to find cacheflush() on OpenBSD.
2011-05-26 3:06 [Qemu-devel] [PATCH 2/3] Use the correct header in the TCG MIPS code to find cacheflush() on OpenBSD Brad
2011-05-30 21:01 ` Brad
@ 2011-06-03 16:24 ` Aurelien Jarno
1 sibling, 0 replies; 7+ messages in thread
From: Aurelien Jarno @ 2011-06-03 16:24 UTC (permalink / raw)
To: Brad; +Cc: qemu-devel
On Wed, May 25, 2011 at 11:06:00PM -0400, Brad wrote:
> Use the correct header in the TCG MIPS code to find cacheflush() on OpenBSD
> to fix compilation of the MIPS host support for OpenBSD/mips64 based architecures.
>
> Signed-off-by: Brad Smith <brad@comstyle.com>
>
> ---
> tcg/mips/tcg-target.h | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
Thanks, applied.
> diff --git a/tcg/mips/tcg-target.h b/tcg/mips/tcg-target.h
> index 0028bfa..8cb7d88 100644
> --- a/tcg/mips/tcg-target.h
> +++ b/tcg/mips/tcg-target.h
> @@ -102,7 +102,11 @@ enum {
> /* guest base is supported */
> #define TCG_TARGET_HAS_GUEST_BASE
>
> +#ifdef __OpenBSD__
> +#include <machine/sysarch.h>
> +#else
> #include <sys/cachectl.h>
> +#endif
>
> static inline void flush_icache_range(unsigned long start, unsigned long stop)
> {
> --
> 1.7.5
>
> --
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-06-03 16:24 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-26 3:06 [Qemu-devel] [PATCH 2/3] Use the correct header in the TCG MIPS code to find cacheflush() on OpenBSD Brad
2011-05-30 21:01 ` Brad
2011-05-30 21:16 ` Andreas Färber
2011-05-30 21:22 ` Brad
2011-05-30 21:24 ` Brad
2011-05-30 21:41 ` Andreas Färber
2011-06-03 16:24 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).