From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57705) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRLbi-0002om-OK for qemu-devel@nongnu.org; Tue, 31 May 2011 05:51:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QRLbh-0005wJ-Vn for qemu-devel@nongnu.org; Tue, 31 May 2011 05:51:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59516) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRLbh-0005wF-MD for qemu-devel@nongnu.org; Tue, 31 May 2011 05:51:25 -0400 Message-ID: <4DE4BA28.2090709@redhat.com> Date: Tue, 31 May 2011 11:51:36 +0200 From: Hans de Goede MIME-Version: 1.0 References: <1306834530-12763-1-git-send-email-hdegoede@redhat.com> <1306834530-12763-15-git-send-email-hdegoede@redhat.com> <4DE4B808.4030104@msgid.tls.msk.ru> In-Reply-To: <4DE4B808.4030104@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 14/14] usb: Proper error propagation for usb_device_attach errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: "qemu-devel@nongnu.org" Hi, On 05/31/2011 11:42 AM, Michael Tokarev wrote: > 31.05.2011 13:35, Hans de Goede wrote: >> --- >> hw/usb-bus.c | 23 ++++++++++++----------- >> hw/usb-msd.c | 5 +++-- >> usb-linux.c | 6 +++++- >> 3 files changed, 20 insertions(+), 14 deletions(-) >> >> diff --git a/hw/usb-bus.c b/hw/usb-bus.c >> index 0a49921..2ae2678 100644 >> --- a/hw/usb-bus.c >> +++ b/hw/usb-bus.c > >> if (dev->attached) { >> - fprintf(stderr, "Warning: tried to attach usb device %s twice\n", >> + fprintf(stderr, "Error: tried to attach usb device %s twice\n", >> dev->product_desc); > > qemu_error() maybe, while we're at it? > Here and in a few other places. That does not seem to exist, do you perhaps mean error_printf() ? Regards, Hans