From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRLtW-0001fu-OQ for qemu-devel@nongnu.org; Tue, 31 May 2011 06:09:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QRLtV-0000Rr-K9 for qemu-devel@nongnu.org; Tue, 31 May 2011 06:09:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRLtV-0000Rn-Ah for qemu-devel@nongnu.org; Tue, 31 May 2011 06:09:49 -0400 Message-ID: <4DE4BF17.8060602@redhat.com> Date: Tue, 31 May 2011 12:12:39 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1306834530-12763-1-git-send-email-hdegoede@redhat.com> <1306834530-12763-15-git-send-email-hdegoede@redhat.com> <4DE4B808.4030104@msgid.tls.msk.ru> <4DE4BA28.2090709@redhat.com> <4DE4BB65.1070800@redhat.com> <4DE4BD6E.1000105@redhat.com> In-Reply-To: <4DE4BD6E.1000105@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 14/14] usb: Proper error propagation for usb_device_attach errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans de Goede Cc: Michael Tokarev , "qemu-devel@nongnu.org" Am 31.05.2011 12:05, schrieb Hans de Goede: > Hi, > > On 05/31/2011 11:56 AM, Kevin Wolf wrote: >> Am 31.05.2011 11:51, schrieb Hans de Goede: >>> Hi, >>> >>> On 05/31/2011 11:42 AM, Michael Tokarev wrote: >>>> 31.05.2011 13:35, Hans de Goede wrote: >>>>> --- >>>>> hw/usb-bus.c | 23 ++++++++++++----------- >>>>> hw/usb-msd.c | 5 +++-- >>>>> usb-linux.c | 6 +++++- >>>>> 3 files changed, 20 insertions(+), 14 deletions(-) >>>>> >>>>> diff --git a/hw/usb-bus.c b/hw/usb-bus.c >>>>> index 0a49921..2ae2678 100644 >>>>> --- a/hw/usb-bus.c >>>>> +++ b/hw/usb-bus.c >>>> >>>>> if (dev->attached) { >>>>> - fprintf(stderr, "Warning: tried to attach usb device %s twice\n", >>>>> + fprintf(stderr, "Error: tried to attach usb device %s twice\n", >>>>> dev->product_desc); >>>> >>>> qemu_error() maybe, while we're at it? >>>> Here and in a few other places. >>> >>> That does not seem to exist, do you perhaps mean error_printf() ? >> >> error_report() is what you should use, so that messages go to the >> monitor if the function is called from a monitor command. error_printf() >> is used by it internally, but usually isn't used directly. >> > > I've looked at error_report, but IMHO it is made of crazy, I'm not going > to construct a json dict every time I need to log some simple error message > (and the existing ones are not suitable for many error messages). error_report() works with plain strings. Maybe you confuse it with the QMP error reporting function? Kevin