From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53338)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QRPB3-0000Ov-Rb
	for qemu-devel@nongnu.org; Tue, 31 May 2011 09:40:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QRPAw-0002nf-JN
	for qemu-devel@nongnu.org; Tue, 31 May 2011 09:40:09 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:55808)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QRPAw-0002nX-Dw
	for qemu-devel@nongnu.org; Tue, 31 May 2011 09:40:02 -0400
Received: by ywl41 with SMTP id 41so2151223ywl.4
	for <qemu-devel@nongnu.org>; Tue, 31 May 2011 06:40:01 -0700 (PDT)
Message-ID: <4DE4EFB0.4030704@codemonkey.ws>
Date: Tue, 31 May 2011 08:40:00 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1306524712-13050-1-git-send-email-lcapitulino@redhat.com>	<1306524712-13050-4-git-send-email-lcapitulino@redhat.com>	<m3oc2njly7.fsf@blackfin.pond.sub.org>	<20110530110955.0c88675d@doriath>	<m3aae4mefh.fsf@blackfin.pond.sub.org>	<4DE4A2E1.5060103@redhat.com>
	<20110531103506.42d7a3ab@doriath>
In-Reply-To: <20110531103506.42d7a3ab@doriath>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] QMP: Introduce the BLOCK_MEDIA_EJECT
 event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, amit.shah@redhat.com, aliguori@us.ibm.com, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

On 05/31/2011 08:35 AM, Luiz Capitulino wrote:
> On Tue, 31 May 2011 10:12:17 +0200
>> Do we break anything if we make eject really eject the medium (we have a
>> virtual tray status now) instead of just closing the image?
>
> I don't think so. I guess users/clients really have the expectation that
> the only result is to get the media ejected.
>
> Now, "-f" can be used with non-removable media. There's some risk of
> breakage here if clients are using this to "unplug" devices. But I think
> this a case where we'll have to pay the price for the breakage (if any).

Only badness can ensue from doing that today so I see no reason to 
preserve this "functionality".

Regards,

Anthony Liguori

>
>> most visible change is that we'll eject the host medium when using
>> pass-through. I consider this an additional bugfix.
>
> Yes.
>