qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
	"Andreas Färber" <andreas.faerber@web.de>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"Avi Kivity" <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Use SIGIO with caution
Date: Tue, 31 May 2011 16:06:26 +0200	[thread overview]
Message-ID: <4DE4F5E2.5020906@siemens.com> (raw)
In-Reply-To: <4DE4F16D.6030009@codemonkey.ws>

On 2011-05-31 15:47, Anthony Liguori wrote:
> On 05/29/2011 04:50 PM, Andreas Färber wrote:
>> BeOS and Haiku don't define SIGIO. When undefined, it won't arrive
>> and doesn't need to be blocked.
>>
>> Signed-off-by: Andreas Färber<andreas.faerber@web.de>
> 
> Anything to do with signal masks is never a trivial patch BTW...
> 
> But I actually think explicit handling of SIGIO is unneeded.  I think 
> this is a hold over from the pre-I/O thread days where we selectively 
> set SIGIO on certain file descriptors to make sure that when an IO fd 
> became readable, we received a signal to break out of the KVM emulation 
> loop.
> 
> Can the folks on CC confirm/deny?
> 
> I can't see any use of SIGIO in the current source tree.

At least qemu-timer.c uses SIGIO in HPET mode. That only applies to
Linux hosts, though.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

  reply	other threads:[~2011-05-31 14:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-29 21:50 [Qemu-devel] [PATCH] Use SIGIO with caution Andreas Färber
2011-05-31 13:47 ` Anthony Liguori
2011-05-31 14:06   ` Jan Kiszka [this message]
2011-05-31 14:26     ` Anthony Liguori
2011-05-31 14:54       ` Jan Kiszka
2011-05-31 15:44         ` Alexander Graf
2011-05-31 15:48           ` Anthony Liguori
2011-05-31 16:16             ` Alexander Graf
2011-05-31 19:49               ` Anthony Liguori
2011-05-31 21:11                 ` Andreas Färber
2011-05-31 21:43                   ` Jan Kiszka
2011-05-31 23:19                     ` Anthony Liguori
2011-05-31 14:11   ` Avi Kivity
2011-05-31 21:24   ` Andreas Färber
2011-06-01 22:30   ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DE4F5E2.5020906@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=andreas.faerber@web.de \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).