From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-trivial@nongnu.org, "Jan Kiszka" <jan.kiszka@siemens.com>,
"Andreas Färber" <andreas.faerber@web.de>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Use SIGIO with caution
Date: Tue, 31 May 2011 17:11:18 +0300 [thread overview]
Message-ID: <4DE4F706.1000507@redhat.com> (raw)
In-Reply-To: <4DE4F16D.6030009@codemonkey.ws>
On 05/31/2011 04:47 PM, Anthony Liguori wrote:
> On 05/29/2011 04:50 PM, Andreas Färber wrote:
>> BeOS and Haiku don't define SIGIO. When undefined, it won't arrive
>> and doesn't need to be blocked.
>>
>> Signed-off-by: Andreas Färber<andreas.faerber@web.de>
>
> Anything to do with signal masks is never a trivial patch BTW...
>
> But I actually think explicit handling of SIGIO is unneeded. I think
> this is a hold over from the pre-I/O thread days where we selectively
> set SIGIO on certain file descriptors to make sure that when an IO fd
> became readable, we received a signal to break out of the KVM
> emulation loop.
>
> Can the folks on CC confirm/deny?
>
> I can't see any use of SIGIO in the current source tree.
>
We have O_ASYNC in enable_sigio_timer(). That's only used with HPET
host timers, which should be very rare.
To be on the safe side I think we should take in the patch, and drop
SIGIO support completely only if we decide the hpet host timer is not
worth supporting.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-05-31 14:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-29 21:50 [Qemu-devel] [PATCH] Use SIGIO with caution Andreas Färber
2011-05-31 13:47 ` Anthony Liguori
2011-05-31 14:06 ` Jan Kiszka
2011-05-31 14:26 ` Anthony Liguori
2011-05-31 14:54 ` Jan Kiszka
2011-05-31 15:44 ` Alexander Graf
2011-05-31 15:48 ` Anthony Liguori
2011-05-31 16:16 ` Alexander Graf
2011-05-31 19:49 ` Anthony Liguori
2011-05-31 21:11 ` Andreas Färber
2011-05-31 21:43 ` Jan Kiszka
2011-05-31 23:19 ` Anthony Liguori
2011-05-31 14:11 ` Avi Kivity [this message]
2011-05-31 21:24 ` Andreas Färber
2011-06-01 22:30 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE4F706.1000507@redhat.com \
--to=avi@redhat.com \
--cc=andreas.faerber@web.de \
--cc=anthony@codemonkey.ws \
--cc=jan.kiszka@siemens.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).