From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44645)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QRPfO-0006M6-Nw
	for qemu-devel@nongnu.org; Tue, 31 May 2011 10:11:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QRPfN-0008DY-Pi
	for qemu-devel@nongnu.org; Tue, 31 May 2011 10:11:30 -0400
Message-ID: <4DE4F706.1000507@redhat.com>
Date: Tue, 31 May 2011 17:11:18 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1306705831-59385-1-git-send-email-andreas.faerber@web.de>
	<4DE4F16D.6030009@codemonkey.ws>
In-Reply-To: <4DE4F16D.6030009@codemonkey.ws>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Use SIGIO with caution
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-trivial@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <andreas.faerber@web.de>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org

On 05/31/2011 04:47 PM, Anthony Liguori wrote:
> On 05/29/2011 04:50 PM, Andreas F=C3=A4rber wrote:
>> BeOS and Haiku don't define SIGIO. When undefined, it won't arrive
>> and doesn't need to be blocked.
>>
>> Signed-off-by: Andreas F=C3=A4rber<andreas.faerber@web.de>
>
> Anything to do with signal masks is never a trivial patch BTW...
>
> But I actually think explicit handling of SIGIO is unneeded.  I think=20
> this is a hold over from the pre-I/O thread days where we selectively=20
> set SIGIO on certain file descriptors to make sure that when an IO fd=20
> became readable, we received a signal to break out of the KVM=20
> emulation loop.
>
> Can the folks on CC confirm/deny?
>
> I can't see any use of SIGIO in the current source tree.
>

We have O_ASYNC in enable_sigio_timer().  That's only used with HPET=20
host timers, which should be very rare.

To be on the safe side I think we should take in the patch, and drop=20
SIGIO support completely only if we decide the hpet host timer is not=20
worth supporting.

--=20
error compiling committee.c: too many arguments to function