From: Richard Henderson <rth@twiddle.net>
To: Nathan Whitehorn <nwhitehorn@freebsd.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ppc64: fix mtmsr behavior on 64-bit targets
Date: Tue, 31 May 2011 10:40:51 -0700 [thread overview]
Message-ID: <4DE52823.4000805@twiddle.net> (raw)
In-Reply-To: <4DE50181.6070902@freebsd.org>
On 05/31/2011 07:56 AM, Nathan Whitehorn wrote:
> #if defined(TARGET_PPC64)
> - if (!ctx->sf_mode) {
> TCGv t0 = tcg_temp_new();
> TCGv t1 = tcg_temp_new();
You're removing a scope in which these variables were defined.
That seems wrong, at minimum.
r~
next prev parent reply other threads:[~2011-05-31 18:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 14:56 [Qemu-devel] [PATCH] ppc64: fix mtmsr behavior on 64-bit targets Nathan Whitehorn
2011-05-31 16:48 ` Alexander Graf
2011-05-31 17:40 ` Richard Henderson [this message]
2011-06-04 19:28 ` Nathan Whitehorn
2011-06-05 9:00 ` Alexander Graf
2011-06-05 13:33 ` Nathan Whitehorn
2011-06-05 13:36 ` Nathan Whitehorn
2011-06-05 13:45 ` Alexander Graf
2011-06-12 15:49 ` [Qemu-devel] [PATCH2] " Nathan Whitehorn
2011-06-13 10:20 ` Alexander Graf
2011-06-13 12:52 ` Nathan Whitehorn
2011-06-13 13:17 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE52823.4000805@twiddle.net \
--to=rth@twiddle.net \
--cc=nwhitehorn@freebsd.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).