From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47215)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QRTON-0004Eh-00
	for qemu-devel@nongnu.org; Tue, 31 May 2011 14:10:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QRTOL-0004hg-LW
	for qemu-devel@nongnu.org; Tue, 31 May 2011 14:10:10 -0400
Received: from mail-gx0-f173.google.com ([209.85.161.173]:45782)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QRTOL-0004h3-8b
	for qemu-devel@nongnu.org; Tue, 31 May 2011 14:10:09 -0400
Received: by gxk26 with SMTP id 26so2261237gxk.4
	for <qemu-devel@nongnu.org>; Tue, 31 May 2011 11:10:08 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4DE52823.4000805@twiddle.net>
Date: Tue, 31 May 2011 10:40:51 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <4DE50181.6070902@freebsd.org>
In-Reply-To: <4DE50181.6070902@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] ppc64: fix mtmsr behavior on 64-bit targets
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nathan Whitehorn <nwhitehorn@freebsd.org>
Cc: qemu-devel@nongnu.org

On 05/31/2011 07:56 AM, Nathan Whitehorn wrote:
>  #if defined(TARGET_PPC64)
> -        if (!ctx->sf_mode) {
>              TCGv t0 = tcg_temp_new();
>              TCGv t1 = tcg_temp_new();

You're removing a scope in which these variables were defined.
That seems wrong, at minimum.


r~