From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRjcD-0006e7-JZ for qemu-devel@nongnu.org; Wed, 01 Jun 2011 07:29:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QRjcC-0000ZJ-8k for qemu-devel@nongnu.org; Wed, 01 Jun 2011 07:29:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRjcB-0000Z7-Nk for qemu-devel@nongnu.org; Wed, 01 Jun 2011 07:29:32 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p51BTUhQ007645 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 1 Jun 2011 07:29:30 -0400 Message-ID: <4DE62298.1030201@redhat.com> Date: Wed, 01 Jun 2011 13:29:28 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1306834530-12763-1-git-send-email-hdegoede@redhat.com> <1306834530-12763-5-git-send-email-hdegoede@redhat.com> In-Reply-To: <1306834530-12763-5-git-send-email-hdegoede@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/14] usb-linux: Don't do perror when errno is not set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans de Goede Cc: qemu-devel@nongnu.org On 05/31/11 11:35, Hans de Goede wrote: > Note that "op" also is not set, so before this change these error paths > would feed NULL to perror. Patch applied. thanks, Gerd