From: Gerd Hoffmann <kraxel@redhat.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 07/14] usb-linux: If opening a device fails remove it from our filter list
Date: Wed, 01 Jun 2011 14:32:54 +0200 [thread overview]
Message-ID: <4DE63176.7040108@redhat.com> (raw)
In-Reply-To: <1306834530-12763-8-git-send-email-hdegoede@redhat.com>
On 05/31/11 11:35, Hans de Goede wrote:
> So that we don't retry to open it every 2 seconds flooding stderr with
> error messages.
The polling here is done intentionally, so the devices catched by the
filter show up in the guest automagically as soon as they are plugged
in. Just zapping the filter on failure isn't the right thing to do here.
We could try to do something more clever than polling sysfs every two
seconds though, such using inotify to watch /sys/bus/usb/devices for new
devices poping up.
cheers,
Gerd
next prev parent reply other threads:[~2011-06-01 12:33 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 9:35 [Qemu-devel] [PATCH 00/14] usb: various usb fixes Hans de Goede
2011-05-31 9:35 ` [Qemu-devel] [PATCH 01/14] usb-linux: Set usb_auto_timer to NULL after deleting it Hans de Goede
2011-06-01 10:48 ` Gerd Hoffmann
2011-06-01 14:24 ` Hans de Goede
2011-05-31 9:35 ` [Qemu-devel] [PATCH 02/14] usb-linux: Get speed from sysfs rather then from the connectinfo ioctl Hans de Goede
2011-06-01 11:25 ` Gerd Hoffmann
2011-05-31 9:35 ` [Qemu-devel] [PATCH 03/14] usb-linux: Teach about super speed Hans de Goede
2011-06-01 11:28 ` Gerd Hoffmann
2011-05-31 9:35 ` [Qemu-devel] [PATCH 04/14] usb-linux: Don't do perror when errno is not set Hans de Goede
2011-06-01 11:29 ` Gerd Hoffmann
2011-06-01 11:43 ` Gerd Hoffmann
2011-05-31 9:35 ` [Qemu-devel] [PATCH 05/14] usb-linux: Don't call usb_host_close when usb_host_open fails Hans de Goede
2011-06-01 12:22 ` Gerd Hoffmann
2011-06-01 14:33 ` Hans de Goede
2011-05-31 9:35 ` [Qemu-devel] [PATCH 06/14] usb-linux: Ensure devep != 0 Hans de Goede
2011-06-01 12:24 ` Gerd Hoffmann
2011-05-31 9:35 ` [Qemu-devel] [PATCH 07/14] usb-linux: If opening a device fails remove it from our filter list Hans de Goede
2011-06-01 12:32 ` Gerd Hoffmann [this message]
2011-06-01 14:37 ` Hans de Goede
2011-06-06 10:24 ` Gerd Hoffmann
2011-05-31 9:35 ` [Qemu-devel] [PATCH 08/14] usb-linux: Don't try to open the same device twice Hans de Goede
2011-06-01 12:35 ` Gerd Hoffmann
2011-05-31 9:35 ` [Qemu-devel] [PATCH 09/14] usb-linux: Don't declare a usbdevice_name Hans de Goede
2011-06-01 12:44 ` Gerd Hoffmann
2011-06-01 14:38 ` Hans de Goede
2011-05-31 9:35 ` [Qemu-devel] [PATCH 10/14] usb-linux: Enlarge buffer for descriptors to 8192 bytes Hans de Goede
2011-06-01 12:44 ` Gerd Hoffmann
2011-05-31 9:35 ` [Qemu-devel] [PATCH 11/14] usb-bus: Add knowledge of USB_SPEED_SUPER to usb_speed helper Hans de Goede
2011-06-01 12:47 ` Gerd Hoffmann
2011-05-31 9:35 ` [Qemu-devel] [PATCH 12/14] usb-bus: Don't allow attaching a device to a bus with no free ports Hans de Goede
2011-05-31 9:35 ` [Qemu-devel] [PATCH 13/14] usb-bus: Don't detach non attached devices on device exit Hans de Goede
2011-06-01 12:51 ` Gerd Hoffmann
2011-05-31 9:35 ` [Qemu-devel] [PATCH 14/14] usb: Proper error propagation for usb_device_attach errors Hans de Goede
2011-05-31 9:42 ` Michael Tokarev
2011-05-31 9:51 ` Hans de Goede
2011-05-31 9:56 ` Kevin Wolf
2011-05-31 10:05 ` Hans de Goede
2011-05-31 10:12 ` Kevin Wolf
2011-05-31 10:13 ` Hans de Goede
2011-06-01 12:50 ` Gerd Hoffmann
2011-06-01 14:42 ` Hans de Goede
2011-06-06 10:27 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE63176.7040108@redhat.com \
--to=kraxel@redhat.com \
--cc=hdegoede@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).