From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRkbb-000330-TV for qemu-devel@nongnu.org; Wed, 01 Jun 2011 08:33:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QRkba-00049P-Dm for qemu-devel@nongnu.org; Wed, 01 Jun 2011 08:32:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3848) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRkbZ-00049J-Tc for qemu-devel@nongnu.org; Wed, 01 Jun 2011 08:32:58 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p51CWumF003782 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 1 Jun 2011 08:32:56 -0400 Message-ID: <4DE63176.7040108@redhat.com> Date: Wed, 01 Jun 2011 14:32:54 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1306834530-12763-1-git-send-email-hdegoede@redhat.com> <1306834530-12763-8-git-send-email-hdegoede@redhat.com> In-Reply-To: <1306834530-12763-8-git-send-email-hdegoede@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/14] usb-linux: If opening a device fails remove it from our filter list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans de Goede Cc: qemu-devel@nongnu.org On 05/31/11 11:35, Hans de Goede wrote: > So that we don't retry to open it every 2 seconds flooding stderr with > error messages. The polling here is done intentionally, so the devices catched by the filter show up in the guest automagically as soon as they are plugged in. Just zapping the filter on failure isn't the right thing to do here. We could try to do something more clever than polling sysfs every two seconds though, such using inotify to watch /sys/bus/usb/devices for new devices poping up. cheers, Gerd