From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRkdj-0003bc-T5 for qemu-devel@nongnu.org; Wed, 01 Jun 2011 08:35:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QRkdi-0004ju-H2 for qemu-devel@nongnu.org; Wed, 01 Jun 2011 08:35:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRkdh-0004j6-M7 for qemu-devel@nongnu.org; Wed, 01 Jun 2011 08:35:10 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p51CZ8de026670 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 1 Jun 2011 08:35:08 -0400 Message-ID: <4DE631FA.4050605@redhat.com> Date: Wed, 01 Jun 2011 14:35:06 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1306834530-12763-1-git-send-email-hdegoede@redhat.com> <1306834530-12763-9-git-send-email-hdegoede@redhat.com> In-Reply-To: <1306834530-12763-9-git-send-email-hdegoede@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 08/14] usb-linux: Don't try to open the same device twice List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans de Goede Cc: qemu-devel@nongnu.org On 05/31/11 11:35, Hans de Goede wrote: > If a user wants to redirect 2 identical usb sticks, in theory this is > possible by doing: > usb_add host:1234:5678 > usb_add host:1234:5678 > > But this will lead to us trying to open the first stick twice, since we > don't break the loop after having found a match in our filter list, so the next' > filter list entry will result in us trying to open the same device again. > > Fix Good catch. Patch applied. thanks, Gerd