From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33448)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QRkmP-0005qg-62
	for qemu-devel@nongnu.org; Wed, 01 Jun 2011 08:44:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QRkmN-0006LC-RY
	for qemu-devel@nongnu.org; Wed, 01 Jun 2011 08:44:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28691)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QRkmN-0006L0-E9
	for qemu-devel@nongnu.org; Wed, 01 Jun 2011 08:44:07 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p51Ci6rg028704
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 1 Jun 2011 08:44:06 -0400
Message-ID: <4DE63414.5030004@redhat.com>
Date: Wed, 01 Jun 2011 14:44:04 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1306834530-12763-1-git-send-email-hdegoede@redhat.com>
	<1306834530-12763-10-git-send-email-hdegoede@redhat.com>
In-Reply-To: <1306834530-12763-10-git-send-email-hdegoede@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 09/14] usb-linux: Don't declare a
	usbdevice_name
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel@nongnu.org

On 05/31/11 11:35, Hans de Goede wrote:
> Declaring a usbdevice_name while we still have an explicit call to
> usb_host_device_open in vl.c causes usb_host_device_open to get called
> twice if the initial call fails.

Wrong way around, the vl.c call should be zapped instead.  Just did.

cheers,
   Gerd