qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: "Cédric VINCENT" <cedric.vincent@st.com>
Cc: Yves JANIN <yves.janin@st.com>, Riku Voipio <riku.voipio@iki.fi>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] linux-user: Fix the load of ELF files that have no "useful" symbol
Date: Wed, 01 Jun 2011 06:19:38 -0700	[thread overview]
Message-ID: <4DE63C6A.6060603@twiddle.net> (raw)
In-Reply-To: <1306931798-2475-1-git-send-email-cedric.vincent@st.com>

On 06/01/2011 05:36 AM, Cédric VINCENT wrote:
> This patch fixes a "double free()" due to "realloc(syms, 0)" in the
> loader when the ELF file has no "useful" symbol, as with the following
> example (compiled with "sh4-linux-gcc -nostdlib"):
> 
>     .text
>     .align 1
>     .global _start
>     _start:
>         mov     #1, r3
>         trapa   #40     // syscall(__NR_exit)
>         nop
> 
> The bug appears when the log (option "-d") is enabled.
> 
> Signed-off-by: Cédric VINCENT <cedric.vincent@st.com>
> Signed-off-by: Yves JANIN <yves.janin@st.com>

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~

      reply	other threads:[~2011-06-01 13:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-01 12:36 [Qemu-devel] [PATCH] linux-user: Fix the load of ELF files that have no "useful" symbol Cédric VINCENT
2011-06-01 13:19 ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DE63C6A.6060603@twiddle.net \
    --to=rth@twiddle.net \
    --cc=cedric.vincent@st.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=yves.janin@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).