From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRmRd-0005Uh-PF for qemu-devel@nongnu.org; Wed, 01 Jun 2011 10:30:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QRmRc-00018t-1y for qemu-devel@nongnu.org; Wed, 01 Jun 2011 10:30:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13433) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRmRb-00018f-7B for qemu-devel@nongnu.org; Wed, 01 Jun 2011 10:30:47 -0400 Message-ID: <4DE64CE4.7030300@redhat.com> Date: Wed, 01 Jun 2011 17:29:56 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1306892315-7306-1-git-send-email-eduard.munteanu@linux360.ro> <1306892315-7306-2-git-send-email-eduard.munteanu@linux360.ro> <4DE64646.3010505@twiddle.net> In-Reply-To: <4DE64646.3010505@twiddle.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: aliguori@us.ibm.com, kvm@vger.kernel.org, mst@redhat.com, aik@ozlabs.ru, joro@8bytes.org, seabios@seabios.org, qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, yamahata@valinux.co.jp, kevin@koconnor.net, paul@codesourcery.com, Eduard - Gabriel Munteanu , dwg@au1.ibm.com, david@gibson.dropbear.id.au On 06/01/2011 05:01 PM, Richard Henderson wrote: > > + err = dev->mmu->translate(dev, addr,&paddr,&plen, is_write); > > I see you didn't take my suggestion for using an opaque callback pointer. > Really and truly, I won't be able to use this as-is for Alpha. > Rather than opaques, please pass the DMA engine itself and use container_of(). We should be removing opaques, not adding them. -- error compiling committee.c: too many arguments to function