From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRmYr-0007Cl-62 for qemu-devel@nongnu.org; Wed, 01 Jun 2011 10:38:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QRmYo-00026o-Fi for qemu-devel@nongnu.org; Wed, 01 Jun 2011 10:38:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRmYo-00026c-3Q for qemu-devel@nongnu.org; Wed, 01 Jun 2011 10:38:14 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p51EcDmM014607 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 1 Jun 2011 10:38:13 -0400 Message-ID: <4DE64EE3.7050305@redhat.com> Date: Wed, 01 Jun 2011 16:38:27 +0200 From: Hans de Goede MIME-Version: 1.0 References: <1306834530-12763-1-git-send-email-hdegoede@redhat.com> <1306834530-12763-10-git-send-email-hdegoede@redhat.com> <4DE63414.5030004@redhat.com> In-Reply-To: <4DE63414.5030004@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/14] usb-linux: Don't declare a usbdevice_name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Hi, On 06/01/2011 02:44 PM, Gerd Hoffmann wrote: > On 05/31/11 11:35, Hans de Goede wrote: >> Declaring a usbdevice_name while we still have an explicit call to >> usb_host_device_open in vl.c causes usb_host_device_open to get called >> twice if the initial call fails. > > Wrong way around, the vl.c call should be zapped instead. Just did. Sounds good to me, but you will also need to fix usb-bsd to declare a usbdevice_name and initfn then. Regards, Hans