From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRmd1-0008If-Bn for qemu-devel@nongnu.org; Wed, 01 Jun 2011 10:42:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QRmcu-0002nw-QC for qemu-devel@nongnu.org; Wed, 01 Jun 2011 10:42:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRmcu-0002ng-6j for qemu-devel@nongnu.org; Wed, 01 Jun 2011 10:42:28 -0400 Message-ID: <4DE64FE1.2000104@redhat.com> Date: Wed, 01 Jun 2011 16:42:41 +0200 From: Hans de Goede MIME-Version: 1.0 References: <1306834530-12763-1-git-send-email-hdegoede@redhat.com> <1306834530-12763-15-git-send-email-hdegoede@redhat.com> <4DE4B808.4030104@msgid.tls.msk.ru> <4DE4BA28.2090709@redhat.com> <4DE4BB65.1070800@redhat.com> <4DE4BD6E.1000105@redhat.com> <4DE4BF17.8060602@redhat.com> <4DE4BF37.2060402@redhat.com> <4DE63599.2060803@redhat.com> In-Reply-To: <4DE63599.2060803@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 14/14] usb: Proper error propagation for usb_device_attach errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Kevin Wolf , Michael Tokarev , "qemu-devel@nongnu.org" Hi, On 06/01/2011 02:50 PM, Gerd Hoffmann wrote: > Hi, > >> I'll wait a bit for more feedback and then change >> [PATCH 14/14] usb: Proper error propagation for usb_device_attach errors > > I'll wait for new revisions of patches 12+14 then. I already fixed this yeterday, I opted to leave patch 12 unmodified and replace all fprintf(stderr, ... calls with error_report calls in one go in a new patch 14. You can find the new version here: http://cgit.freedesktop.org/~jwrdegoede/qemu/commit/?h=usb-patches&id=3c0be7730ff74a5cdac6aa100179b15c9392ab5f Let me know if you'd rather have me resend 12 + 14 to the list. Regards, Hans