From: David Ahern <daahern@cisco.com>
To: Christophe Fergeau <cfergeau@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] ehci: Fix unused-but-set-variable warning
Date: Wed, 01 Jun 2011 09:53:46 -0600 [thread overview]
Message-ID: <4DE6608A.7080809@cisco.com> (raw)
In-Reply-To: <1306932992-30075-3-git-send-email-cfergeau@redhat.com>
On 06/01/2011 06:56 AM, Christophe Fergeau wrote:
> @@ -1134,11 +1128,8 @@ static int ehci_process_itd(EHCIState *ehci,
>
> DPRINTF("ISOCH: buffer %08X len %d\n", ptr, len);
>
> - if (!dir) {
> + if (!dir)
> cpu_physical_memory_rw(ptr, &ehci->buffer[0], len, 0);
> - pid = USB_TOKEN_OUT;
> - } else
> - pid = USB_TOKEN_IN;
>
> ret = USB_RET_NODEV;
>
I think you want those to be ehci->pid instead of deleting them.
David
next prev parent reply other threads:[~2011-06-01 22:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 12:56 [Qemu-devel] [PATCH 0/3] Fix unused-but-set-variable warnings Christophe Fergeau
2011-06-01 12:56 ` [Qemu-devel] [PATCH 1/3] lsi: Fix unused-but-set-variable warning Christophe Fergeau
2011-06-01 14:19 ` Paolo Bonzini
2011-06-10 16:36 ` Peter Maydell
2011-06-10 19:21 ` Richard Henderson
2011-06-10 18:45 ` Stefan Hajnoczi
2011-06-01 12:56 ` [Qemu-devel] [PATCH 2/3] ehci: " Christophe Fergeau
2011-06-01 15:53 ` David Ahern [this message]
2011-06-01 16:21 ` Christophe Fergeau
2011-06-01 12:56 ` [Qemu-devel] [PATCH 3/3] linux-user: " Christophe Fergeau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE6608A.7080809@cisco.com \
--to=daahern@cisco.com \
--cc=cfergeau@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).