From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46685)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <daahern@cisco.com>) id 1QRtoT-0006K6-FC
	for qemu-devel@nongnu.org; Wed, 01 Jun 2011 18:22:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <daahern@cisco.com>) id 1QRtoR-0003c2-Ra
	for qemu-devel@nongnu.org; Wed, 01 Jun 2011 18:22:53 -0400
Received: from sj-iport-2.cisco.com ([171.71.176.71]:63120)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <daahern@cisco.com>) id 1QRnjy-0006ug-0X
	for qemu-devel@nongnu.org; Wed, 01 Jun 2011 11:53:50 -0400
Message-ID: <4DE6608A.7080809@cisco.com>
Date: Wed, 01 Jun 2011 09:53:46 -0600
From: David Ahern <daahern@cisco.com>
MIME-Version: 1.0
References: <1306932992-30075-1-git-send-email-cfergeau@redhat.com>
	<1306932992-30075-3-git-send-email-cfergeau@redhat.com>
In-Reply-To: <1306932992-30075-3-git-send-email-cfergeau@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] ehci: Fix unused-but-set-variable
	warning
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christophe Fergeau <cfergeau@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

On 06/01/2011 06:56 AM, Christophe Fergeau wrote:
> @@ -1134,11 +1128,8 @@ static int ehci_process_itd(EHCIState *ehci,
>  
>              DPRINTF("ISOCH: buffer %08X len %d\n", ptr, len);
>  
> -            if (!dir) {
> +            if (!dir)
>                  cpu_physical_memory_rw(ptr, &ehci->buffer[0], len, 0);
> -                pid = USB_TOKEN_OUT;
> -            } else
> -                pid = USB_TOKEN_IN;
>  
>              ret = USB_RET_NODEV;
>  

I think you want those to be ehci->pid instead of deleting them.

David