From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:34180)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QSDZi-0007mQ-RQ
	for qemu-devel@nongnu.org; Thu, 02 Jun 2011 15:28:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QSDZh-0006M8-Pu
	for qemu-devel@nongnu.org; Thu, 02 Jun 2011 15:28:58 -0400
Received: from mail-px0-f174.google.com ([209.85.212.174]:44113)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QSDZh-0006Lq-3G
	for qemu-devel@nongnu.org; Thu, 02 Jun 2011 15:28:57 -0400
Received: by pxi15 with SMTP id 15so787447pxi.33
	for <qemu-devel@nongnu.org>; Thu, 02 Jun 2011 12:28:55 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4DE7E475.2010201@twiddle.net>
Date: Thu, 02 Jun 2011 12:28:53 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1307027562-3460-1-git-send-email-david@gibson.dropbear.id.au>
	<1307027562-3460-2-git-send-email-david@gibson.dropbear.id.au>
	<4DE7BDB4.1060601@twiddle.net> <20110602173507.GA4735@localhost>
In-Reply-To: <20110602173507.GA4735@localhost>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 01/14] Generic DMA memory access interface
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Cc: qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>

On 06/02/2011 10:35 AM, Eduard - Gabriel Munteanu wrote:
> My latest patches seem to have fixed that:
> 
> +    if (plen < *len) {
> +        *len = plen;
> +    }
> +
> +    buf = cpu_physical_memory_map(paddr, len, is_write);

No, len is (or was in previous patches) dma_addr_t which
is not the same as target_phys_addr_t.

Which is why plen was used before, because it was the 
right type.


r~