From: riku voipio <riku.voipio@iki.fi>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Peter Maydell <peter.maydell@linaro.org>,
juha.riihimaki@nokia.com, qemu-devel@nongnu.org,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] target-arm: Move VLD/VST multiple into helper functions
Date: Mon, 06 Jun 2011 10:18:09 +0300 [thread overview]
Message-ID: <4DEC7F31.1030503@iki.fi> (raw)
In-Reply-To: <20110603204722.GE14583@volta.aurel32.net>
On 06/03/2011 11:47 PM, Aurelien Jarno wrote:
> On Mon, May 02, 2011 at 05:01:24PM +0100, Peter Maydell wrote:
>> On 20 April 2011 15:52, Peter Maydell<peter.maydell@linaro.org> wrote:
>>> Move VLD/VST multiple into helper functions, as some cases can
>>> generate more TCG ops than the maximum per-instruction limit
>>> and certainly more than the recommended 20.
>> I've had a review comment in private email that this patch
>> slows down ffmpeg by a little over 4% (in a linux-user execution
>> run where about 5% of instructions were an affected vld/vst). So
>> perhaps the right approach is to increase the max-ops-per-insn limit
>> and update the guidance in tcg/README instead?
> Does this patch fixes a real issue (ie most probably a crash), or it is
> just to make the arm target compliant with the README?
Yes, it (or the similar patch in meego qemu) did fix an real issue. IIRC
when running pixman code where vld4.8 variant of instruction was used.
Riku
prev parent reply other threads:[~2011-06-06 7:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 14:52 [Qemu-devel] [PATCH] target-arm: Move VLD/VST multiple into helper functions Peter Maydell
2011-04-28 11:31 ` Peter Maydell
2011-05-02 16:01 ` Peter Maydell
2011-06-03 20:47 ` Aurelien Jarno
2011-06-04 10:01 ` Peter Maydell
2011-06-06 7:18 ` riku voipio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEC7F31.1030503@iki.fi \
--to=riku.voipio@iki.fi \
--cc=aurelien@aurel32.net \
--cc=juha.riihimaki@nokia.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).