From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:50485)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <riku.voipio@iki.fi>) id 1QTU4v-0006Na-Vy
	for qemu-devel@nongnu.org; Mon, 06 Jun 2011 03:18:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <riku.voipio@iki.fi>) id 1QTU4u-0005Yd-B5
	for qemu-devel@nongnu.org; Mon, 06 Jun 2011 03:18:25 -0400
Received: from afflict.kos.to ([92.243.29.197]:60564)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <riku.voipio@iki.fi>) id 1QTU4t-0005YD-TV
	for qemu-devel@nongnu.org; Mon, 06 Jun 2011 03:18:24 -0400
Message-ID: <4DEC7F31.1030503@iki.fi>
Date: Mon, 06 Jun 2011 10:18:09 +0300
From: riku voipio <riku.voipio@iki.fi>
MIME-Version: 1.0
References: <1303311120-3424-1-git-send-email-peter.maydell@linaro.org>	<BANLkTim8rz4EuWKGm0Bqc5yG03sMho21Kw@mail.gmail.com>
	<20110603204722.GE14583@volta.aurel32.net>
In-Reply-To: <20110603204722.GE14583@volta.aurel32.net>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-arm: Move VLD/VST multiple into
 helper functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Peter Maydell <peter.maydell@linaro.org>, juha.riihimaki@nokia.com, qemu-devel@nongnu.org, patches@linaro.org

On 06/03/2011 11:47 PM, Aurelien Jarno wrote:
> On Mon, May 02, 2011 at 05:01:24PM +0100, Peter Maydell wrote:
>> On 20 April 2011 15:52, Peter Maydell<peter.maydell@linaro.org>  wrote:
>>> Move VLD/VST multiple into helper functions, as some cases can
>>> generate more TCG ops than the maximum per-instruction limit
>>> and certainly more than the recommended 20.

>> I've had a review comment in private email that this patch
>> slows down ffmpeg by a little over 4% (in a linux-user execution
>> run where about 5% of instructions were an affected vld/vst). So
>> perhaps the right approach is to increase the max-ops-per-insn limit
>> and update the guidance in tcg/README instead?

> Does this patch fixes a real issue (ie most probably a crash), or it is
> just to make the arm target compliant with the README?

Yes, it (or the similar patch in meego qemu) did fix an real issue. IIRC 
when running pixman code where vld4.8 variant of instruction was used.

Riku