From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51720)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QTg6V-0003fl-Qk
	for qemu-devel@nongnu.org; Mon, 06 Jun 2011 16:08:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QTg6U-0005cM-GV
	for qemu-devel@nongnu.org; Mon, 06 Jun 2011 16:08:51 -0400
Received: from mail-gw0-f45.google.com ([74.125.83.45]:47282)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QTg6U-0005cI-4Y
	for qemu-devel@nongnu.org; Mon, 06 Jun 2011 16:08:50 -0400
Received: by gwb19 with SMTP id 19so1836666gwb.4
	for <qemu-devel@nongnu.org>; Mon, 06 Jun 2011 13:08:49 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4DED33CA.8010302@twiddle.net>
Date: Mon, 06 Jun 2011 15:08:42 -0500
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1307377259-41434-1-git-send-email-andreas.faerber@web.de>	<1307377259-41434-2-git-send-email-andreas.faerber@web.de>	<1307377259-41434-3-git-send-email-andreas.faerber@web.de>	<1307377259-41434-4-git-send-email-andreas.faerber@web.de>	<1307377259-41434-5-git-send-email-andreas.faerber@web.de>
	<1307377259-41434-6-git-send-email-andreas.faerber@web.de>
In-Reply-To: <1307377259-41434-6-git-send-email-andreas.faerber@web.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RFC 05/10] serial: Allow to reconfigure ISA I/O
 base
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <andreas.faerber@web.de>
Cc: hpoussin@reactos.org, qemu-devel@nongnu.org, kraxel@redhat.com

On 06/06/2011 11:20 AM, Andreas Färber wrote:
> +    if (iobase != isa->iobase) {
> +        isa->iobase = iobase;
> +        serial_isa_init_iobase(isa);

Forgot to unregister here?


r~