From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/3] move WORDS_ALIGNED to qemu-common.h
Date: Mon, 06 Jun 2011 22:24:57 +0200 [thread overview]
Message-ID: <4DED3799.5070007@redhat.com> (raw)
In-Reply-To: <CEE0589A-A662-4FE8-81BB-E686E4D6A521@web.de>
On 06/06/2011 07:15 PM, Andreas Färber wrote:
> Am 06.06.2011 um 16:25 schrieb Paolo Bonzini:
>
>> This is not a CPU interface.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
>> diff --git a/qemu-common.h b/qemu-common.h
>> index b851b20..7484ef8 100644
>> --- a/qemu-common.h
>> +++ b/qemu-common.h
>> @@ -4,6 +4,10 @@
>>
>> #include "config-host.h"
>>
>> +#if defined(__arm__) || defined(__sparc__) || defined(__mips__) ||
>> defined(__hppa__) || defined(__ia64__)
>> +#define WORDS_ALIGNED
>> +#endif
>
> Since it depends on the host and you're placing it directly under
> config-host.h inclusion, might it make sense to move the decision into
> configure instead, so that it ends up in config-host.h?
Richard's suggestion will get rid of this altogether.
Paolo
next prev parent reply other threads:[~2011-06-06 20:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 14:25 [Qemu-devel] [PATCH v2 0/3] make endian-independent unaligned memory access functions available to libhw Paolo Bonzini
2011-06-06 14:25 ` [Qemu-devel] [PATCH v2 1/3] move WORDS_ALIGNED to qemu-common.h Paolo Bonzini
2011-06-06 17:15 ` Andreas Färber
2011-06-06 20:24 ` Paolo Bonzini [this message]
2011-06-06 22:15 ` Richard Henderson
2011-06-07 9:17 ` Paolo Bonzini
2011-06-06 14:25 ` [Qemu-devel] [PATCH v2 2/3] softfloat: change default nan definitions to variables Paolo Bonzini
2011-06-06 14:25 ` [Qemu-devel] [PATCH v2 3/3] move unaligned memory access functions to bswap.h Paolo Bonzini
2011-06-06 19:56 ` Richard Henderson
2011-06-06 20:27 ` Paolo Bonzini
2011-06-06 22:05 ` Richard Henderson
2011-06-06 23:07 ` malc
2011-06-07 16:54 ` Richard Henderson
2011-06-07 17:29 ` malc
2011-07-06 13:29 ` [Qemu-devel] [PATCH v2 0/3] make endian-independent unaligned memory access functions available to libhw Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DED3799.5070007@redhat.com \
--to=pbonzini@redhat.com \
--cc=andreas.faerber@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).