From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTgMC-0007oI-8P for qemu-devel@nongnu.org; Mon, 06 Jun 2011 16:25:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QTgMA-0008Mo-NS for qemu-devel@nongnu.org; Mon, 06 Jun 2011 16:25:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9768) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTgMA-0008MN-4y for qemu-devel@nongnu.org; Mon, 06 Jun 2011 16:25:02 -0400 Message-ID: <4DED3799.5070007@redhat.com> Date: Mon, 06 Jun 2011 22:24:57 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1307370348-28400-1-git-send-email-pbonzini@redhat.com> <1307370348-28400-2-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 1/3] move WORDS_ALIGNED to qemu-common.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: qemu-devel@nongnu.org On 06/06/2011 07:15 PM, Andreas F=E4rber wrote: > Am 06.06.2011 um 16:25 schrieb Paolo Bonzini: > >> This is not a CPU interface. >> >> Signed-off-by: Paolo Bonzini > >> diff --git a/qemu-common.h b/qemu-common.h >> index b851b20..7484ef8 100644 >> --- a/qemu-common.h >> +++ b/qemu-common.h >> @@ -4,6 +4,10 @@ >> >> #include "config-host.h" >> >> +#if defined(__arm__) || defined(__sparc__) || defined(__mips__) || >> defined(__hppa__) || defined(__ia64__) >> +#define WORDS_ALIGNED >> +#endif > > Since it depends on the host and you're placing it directly under > config-host.h inclusion, might it make sense to move the decision into > configure instead, so that it ends up in config-host.h? Richard's suggestion will get rid of this altogether. Paolo