Re: [Qemu-devel] [PATCH 08/31] usb-ehci: multiqueue support

[Gerd Hoffmann <kraxel@redhat.com>]

On 06/06/11 16:50, David Ahern wrote:
>>
>> >  +/*
>> >  + *  Write the qh back to guest physical memory.  This step isn't
>> >  + *  in the EHCI spec but we need to do it since we don't share
>> >  + *  physical memory with our guest VM.
>> >  + *
>> >  + *  The first three bytes are read-only for the EHCI, so skip them
>> >  + *  when writing back the qh.
>> >  + */
>> >  +static void ehci_flush_qh(EHCIQueue *q)
>> >  +{
>> >  +    uint32_t *qh = (uint32_t *)&q->qh;
>> >  +    uint32_t dwords = sizeof(EHCIqh)>>  2;
>> >  +    uint32_t addr = NLPTR_GET(q->qhaddr);
>> >  +
>> >  +    put_dwords(addr + 3 * sizeof(uint32_t), qh + 3, dwords - 3);
>> >  +}
> 3 bytes or 3 words?  Comment above says skip 3 bytes.

3 dwords.  I'll fix the comment.

thanks,
   Gerd