From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTqkE-0006Bd-CX for qemu-devel@nongnu.org; Tue, 07 Jun 2011 03:30:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QTqkC-0004Xg-RI for qemu-devel@nongnu.org; Tue, 07 Jun 2011 03:30:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6030) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTqkC-0004Xa-BN for qemu-devel@nongnu.org; Tue, 07 Jun 2011 03:30:32 -0400 Message-ID: <4DEDD390.5090502@redhat.com> Date: Tue, 07 Jun 2011 09:30:24 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1307363962-27223-1-git-send-email-kraxel@redhat.com> <1307363962-27223-9-git-send-email-kraxel@redhat.com> <4DECE93E.7080900@cisco.com> In-Reply-To: <4DECE93E.7080900@cisco.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 08/31] usb-ehci: multiqueue support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Ahern Cc: qemu-devel@nongnu.org On 06/06/11 16:50, David Ahern wrote: >> >> > +/* >> > + * Write the qh back to guest physical memory. This step isn't >> > + * in the EHCI spec but we need to do it since we don't share >> > + * physical memory with our guest VM. >> > + * >> > + * The first three bytes are read-only for the EHCI, so skip them >> > + * when writing back the qh. >> > + */ >> > +static void ehci_flush_qh(EHCIQueue *q) >> > +{ >> > + uint32_t *qh = (uint32_t *)&q->qh; >> > + uint32_t dwords = sizeof(EHCIqh)>> 2; >> > + uint32_t addr = NLPTR_GET(q->qhaddr); >> > + >> > + put_dwords(addr + 3 * sizeof(uint32_t), qh + 3, dwords - 3); >> > +} > 3 bytes or 3 words? Comment above says skip 3 bytes. 3 dwords. I'll fix the comment. thanks, Gerd