From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTsEN-0002g7-ST for qemu-devel@nongnu.org; Tue, 07 Jun 2011 05:05:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QTsEM-0002fN-CA for qemu-devel@nongnu.org; Tue, 07 Jun 2011 05:05:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33147) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTsEM-0002fD-1H for qemu-devel@nongnu.org; Tue, 07 Jun 2011 05:05:46 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5795iiE030803 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 7 Jun 2011 05:05:45 -0400 Message-ID: <4DEDE9E6.5030304@redhat.com> Date: Tue, 07 Jun 2011 11:05:42 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1307369780-28189-1-git-send-email-pbonzini@redhat.com> <1307369780-28189-4-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 3/3] spapr: make irq customizable via qdev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org On 06/07/2011 09:51 AM, Markus Armbruster wrote: >> > diff --git a/hw/spapr_vio.c b/hw/spapr_vio.c >> > index 6f34159..a193caa 100644 >> > --- a/hw/spapr_vio.c >> > +++ b/hw/spapr_vio.c >> > @@ -52,6 +52,10 @@ >> > static struct BusInfo spapr_vio_bus_info = { >> > .name = "spapr-vio", >> > .size = sizeof(VIOsPAPRBus), >> > + .props = (Property[]) { >> > + DEFINE_PROP_UINT32("irq", VIOsPAPRDevice, vio_irq_num, 0), \ >> > + DEFINE_PROP_END_OF_LIST(), >> > + }, >> > }; > > Out of this patch's scope, but I need to ask anyway: do devices on a > spapr-vio bus have a unique address? If yes, what is it? That would be the "reg" value in DEFINE_SPAPR_PROPERTIES (patch 2). I didn't make it a bus property because the default values varies according to the device type. > Is it okay to share interrupts? Seems to work. :) Paolo