From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTww6-0004ez-0r for qemu-devel@nongnu.org; Tue, 07 Jun 2011 10:07:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QTww4-0004kG-83 for qemu-devel@nongnu.org; Tue, 07 Jun 2011 10:07:13 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:44916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTww3-0004jm-UV for qemu-devel@nongnu.org; Tue, 07 Jun 2011 10:07:12 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e6.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p57Dgphk022768 for ; Tue, 7 Jun 2011 09:42:51 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p57E7011027130 for ; Tue, 7 Jun 2011 10:07:00 -0400 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p5786QPK010097 for ; Tue, 7 Jun 2011 02:06:26 -0600 Message-ID: <4DEE306A.60103@linux.vnet.ibm.com> Date: Tue, 07 Jun 2011 10:06:34 -0400 From: Stefan Berger MIME-Version: 1.0 References: <4DDE9466.9030300@linux.vnet.ibm.com> <20110526182648.GS31654@playa.tlv.redhat.com> In-Reply-To: <20110526182648.GS31654@playa.tlv.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Buildfix: fix libcacard build with -m32 on 64bit machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Anthony Liguori , =?ISO-8859-1?Q?Andreas_F=E4rber?= On 05/26/2011 02:26 PM, Alon Levy wrote: > On Thu, May 26, 2011 at 01:56:54PM -0400, Stefan Berger wrote: >> When configuring with --extra-cflags="-m32" on a 64bit machine the >> following error appears during compilation: > Thanks for the fix. Anybody else who thinks that this patch below is necessary? Stefan > Reviewed-by: Alon Levy > >> make -C libhw64 V="1" TARGET_DIR="libhw64/" all >> make[1]: Entering directory `/root/tmp/qemu-git/libhw64' >> make[1]: Leaving directory `/root/tmp/qemu-git/libhw64' >> make -C libcacard V="1" TARGET_DIR="libcacard/" all >> make[1]: Entering directory `/root/tmp/qemu-git/libcacard' >> gcc -lssl3 -lsmime3 -lnss3 -lnssutil3 -lplds4 -lplc4 -lnspr4 >> -lpthread -ldl -lrt -o vscclient cac.o event.o vcard.o vreader.o >> vcard_emul_nss.o vcard_emul_type.o card_7816.o ../osdep.o >> ../oslib-posix.o ../qemu-thread-posix.o ../trace.o ../qemu-malloc.o >> ../qemu-timer-common.o vscclient.o >> cac.o: could not read symbols: File in wrong format >> collect2: ld returned 1 exit status >> make[1]: *** [vscclient] Error 1 >> make[1]: Leaving directory `/root/tmp/qemu-git/libcacard' >> make: *** [subdir-libcacard] Error 2 >> >> The LDFLAGS are not passed to the compiled. The below patch fixes it. >> >> Signed-off-by: Stefan Berger >> >> --- >> libcacard/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Index: qemu-git/libcacard/Makefile >> =================================================================== >> --- qemu-git.orig/libcacard/Makefile >> +++ qemu-git/libcacard/Makefile >> @@ -9,7 +9,7 @@ QEMU_OBJS=$(addprefix ../, $(oslib-obj-y >> QEMU_CFLAGS+=-I../ >> >> vscclient: $(libcacard-y) $(QEMU_OBJS) vscclient.o >> - $(call quiet-command,$(CC) $(libcacard_libs) -lrt -o $@ $^," >> LINK $(TARGET_DIR)$@") >> + $(call quiet-command,$(CC) $(LDFLAGS) $(libcacard_libs) -lrt -o >> $@ $^," LINK $(TARGET_DIR)$@") >> >> all: vscclient >> >>