[Qemu-devel] [PATCH] virtio: Move virtio-pci to hw library

[Qemu-devel] [PATCH] virtio: Move virtio-pci to hw library

[Jan Kiszka]

This module has no target dependencies (except for target_phys_addr_t
size) and can thus be built as part of libhw.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 Makefile.objs   |    1 +
 Makefile.target |    1 -
 2 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile.objs b/Makefile.objs
index fad1dce..3192bf5 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -171,6 +171,7 @@ user-obj-y += cutils.o cache-utils.o
 hw-obj-y =
 hw-obj-y += vl.o loader.o
 hw-obj-$(CONFIG_VIRTIO) += virtio.o virtio-console.o
+hw-obj-$(CONFIG_VIRTIO_PCI) += virtio-pci.o
 hw-obj-y += fw_cfg.o
 hw-obj-$(CONFIG_PCI) += pci.o pci_bridge.o
 hw-obj-$(CONFIG_PCI) += msix.o msi.o
diff --git a/Makefile.target b/Makefile.target
index cfc7091..5da9e59 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -191,7 +191,6 @@ obj-y = arch_init.o cpus.o monitor.o machine.o gdbstub.o balloon.o
 # need to fix this properly
 obj-$(CONFIG_NO_PCI) += pci-stub.o
 obj-$(CONFIG_VIRTIO) += virtio-blk.o virtio-balloon.o virtio-net.o virtio-serial-bus.o
-obj-$(CONFIG_VIRTIO_PCI) += virtio-pci.o
 obj-y += vhost_net.o
 obj-$(CONFIG_VHOST_NET) += vhost.o
 obj-$(CONFIG_REALLY_VIRTFS) += virtio-9p.o
-- 
1.7.1

Re: [Qemu-devel] [PATCH] virtio: Move virtio-pci to hw library

[Aurelien Jarno]

On Tue, Apr 26, 2011 at 01:32:08PM +0200, Jan Kiszka wrote:
> This module has no target dependencies (except for target_phys_addr_t
> size) and can thus be built as part of libhw.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  Makefile.objs   |    1 +
>  Makefile.target |    1 -
>  2 files changed, 1 insertions(+), 1 deletions(-)

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

> diff --git a/Makefile.objs b/Makefile.objs
> index fad1dce..3192bf5 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -171,6 +171,7 @@ user-obj-y += cutils.o cache-utils.o
>  hw-obj-y =
>  hw-obj-y += vl.o loader.o
>  hw-obj-$(CONFIG_VIRTIO) += virtio.o virtio-console.o
> +hw-obj-$(CONFIG_VIRTIO_PCI) += virtio-pci.o
>  hw-obj-y += fw_cfg.o
>  hw-obj-$(CONFIG_PCI) += pci.o pci_bridge.o
>  hw-obj-$(CONFIG_PCI) += msix.o msi.o
> diff --git a/Makefile.target b/Makefile.target
> index cfc7091..5da9e59 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -191,7 +191,6 @@ obj-y = arch_init.o cpus.o monitor.o machine.o gdbstub.o balloon.o
>  # need to fix this properly
>  obj-$(CONFIG_NO_PCI) += pci-stub.o
>  obj-$(CONFIG_VIRTIO) += virtio-blk.o virtio-balloon.o virtio-net.o virtio-serial-bus.o
> -obj-$(CONFIG_VIRTIO_PCI) += virtio-pci.o
>  obj-y += vhost_net.o
>  obj-$(CONFIG_VHOST_NET) += vhost.o
>  obj-$(CONFIG_REALLY_VIRTFS) += virtio-9p.o
> -- 
> 1.7.1
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

Re: [Qemu-devel] [PATCH] virtio: Move virtio-pci to hw library

[Jan Kiszka]

On 2011-05-15 00:44, Aurelien Jarno wrote:
> On Tue, Apr 26, 2011 at 01:32:08PM +0200, Jan Kiszka wrote:
>> This module has no target dependencies (except for target_phys_addr_t
>> size) and can thus be built as part of libhw.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  Makefile.objs   |    1 +
>>  Makefile.target |    1 -
>>  2 files changed, 1 insertions(+), 1 deletions(-)
> 
> Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

Will you or qemu-trivial pick it up?

Jan

> 
>> diff --git a/Makefile.objs b/Makefile.objs
>> index fad1dce..3192bf5 100644
>> --- a/Makefile.objs
>> +++ b/Makefile.objs
>> @@ -171,6 +171,7 @@ user-obj-y += cutils.o cache-utils.o
>>  hw-obj-y =
>>  hw-obj-y += vl.o loader.o
>>  hw-obj-$(CONFIG_VIRTIO) += virtio.o virtio-console.o
>> +hw-obj-$(CONFIG_VIRTIO_PCI) += virtio-pci.o
>>  hw-obj-y += fw_cfg.o
>>  hw-obj-$(CONFIG_PCI) += pci.o pci_bridge.o
>>  hw-obj-$(CONFIG_PCI) += msix.o msi.o
>> diff --git a/Makefile.target b/Makefile.target
>> index cfc7091..5da9e59 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -191,7 +191,6 @@ obj-y = arch_init.o cpus.o monitor.o machine.o gdbstub.o balloon.o
>>  # need to fix this properly
>>  obj-$(CONFIG_NO_PCI) += pci-stub.o
>>  obj-$(CONFIG_VIRTIO) += virtio-blk.o virtio-balloon.o virtio-net.o virtio-serial-bus.o
>> -obj-$(CONFIG_VIRTIO_PCI) += virtio-pci.o
>>  obj-y += vhost_net.o
>>  obj-$(CONFIG_VHOST_NET) += vhost.o
>>  obj-$(CONFIG_REALLY_VIRTFS) += virtio-9p.o
>> -- 
>> 1.7.1
>>
>>
> 

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

Re: [Qemu-devel] [PATCH] virtio: Move virtio-pci to hw library

[Stefan Hajnoczi]

On Tue, Jun 07, 2011 at 05:55:01PM +0200, Jan Kiszka wrote:
> On 2011-05-15 00:44, Aurelien Jarno wrote:
> > On Tue, Apr 26, 2011 at 01:32:08PM +0200, Jan Kiszka wrote:
> >> This module has no target dependencies (except for target_phys_addr_t
> >> size) and can thus be built as part of libhw.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >> ---
> >>  Makefile.objs   |    1 +
> >>  Makefile.target |    1 -
> >>  2 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
> 
> Will you or qemu-trivial pick it up?

Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches

Stefan