From: Richard Henderson <rth@twiddle.net>
To: malc <av1474@comtv.ru>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 3/3] move unaligned memory access functions to bswap.h
Date: Tue, 07 Jun 2011 09:54:34 -0700 [thread overview]
Message-ID: <4DEE57CA.8070902@twiddle.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1106070302450.2524@linmac>
On 06/06/2011 04:07 PM, malc wrote:
> Depends on how bswap_16 is defined. If it is __builtin_bswap16
> then 4.5.0 and 4.6.0 generate byte reversed loads, and previous
> versions lack that builtin, so i don't think this generic code
> should go in.
It would continue to be defined as-is, without direct reference
to the __builtin_bswap functions. But you're right that the
generic code would depend on the bswap optimization pass that
recognizes the mask/shift/or pattern and converts it to the
builtins internally.
What if we kept the ppc ifdefs, but converted the rest to the
gcc generic code?
r~
next prev parent reply other threads:[~2011-06-07 16:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 14:25 [Qemu-devel] [PATCH v2 0/3] make endian-independent unaligned memory access functions available to libhw Paolo Bonzini
2011-06-06 14:25 ` [Qemu-devel] [PATCH v2 1/3] move WORDS_ALIGNED to qemu-common.h Paolo Bonzini
2011-06-06 17:15 ` Andreas Färber
2011-06-06 20:24 ` Paolo Bonzini
2011-06-06 22:15 ` Richard Henderson
2011-06-07 9:17 ` Paolo Bonzini
2011-06-06 14:25 ` [Qemu-devel] [PATCH v2 2/3] softfloat: change default nan definitions to variables Paolo Bonzini
2011-06-06 14:25 ` [Qemu-devel] [PATCH v2 3/3] move unaligned memory access functions to bswap.h Paolo Bonzini
2011-06-06 19:56 ` Richard Henderson
2011-06-06 20:27 ` Paolo Bonzini
2011-06-06 22:05 ` Richard Henderson
2011-06-06 23:07 ` malc
2011-06-07 16:54 ` Richard Henderson [this message]
2011-06-07 17:29 ` malc
2011-07-06 13:29 ` [Qemu-devel] [PATCH v2 0/3] make endian-independent unaligned memory access functions available to libhw Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEE57CA.8070902@twiddle.net \
--to=rth@twiddle.net \
--cc=av1474@comtv.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).