From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55267)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1QU3xm-0005sq-Cy
	for qemu-devel@nongnu.org; Tue, 07 Jun 2011 17:37:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1QU3xk-0005Hp-Q0
	for qemu-devel@nongnu.org; Tue, 07 Jun 2011 17:37:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17484)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1QU3xk-0005HC-3M
	for qemu-devel@nongnu.org; Tue, 07 Jun 2011 17:37:24 -0400
Message-ID: <4DEE9A72.6020301@redhat.com>
Date: Tue, 07 Jun 2011 17:38:58 -0400
From: Cole Robinson <crobinso@redhat.com>
MIME-Version: 1.0
References: <cover.1307465139.git.jan.kiszka@siemens.com>	<893bbf06226ec15c6e1bcc99e3e3263dfaf89332.1307465139.git.jan.kiszka@siemens.com>
	<4DEE824E.7080209@codemonkey.ws>
In-Reply-To: <4DEE824E.7080209@codemonkey.ws>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 6/9] net: Improve layout of 'info network'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: "libvir-list@redhat.com" <libvir-list@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

On 06/07/2011 03:55 PM, Anthony Liguori wrote:
> On 06/07/2011 11:45 AM, Jan Kiszka wrote:
>> Improve the layout when listing non-vlan clients via 'info network'. The
>> result looks like this:
>>
>> (qemu) info network
>> Devices not on any VLAN:
>>    orphan: net=10.0.2.0, restricted=n
>>    virtio-net-pci.0: model=virtio-net-pci,macaddr=52:54:00:12:34:56
>>     \ network2: fd=5
>>    e1000.0: model=e1000,macaddr=52:54:00:12:34:57
>>     \ network1: net=10.0.2.0, restricted=n
>>    rtl8139.0: model=rtl8139,macaddr=52:54:00:12:34:58
>>
>> ie. peers are grouped, orphans are listed as before.
>>
>> CC: Markus Armbruster<armbru@redhat.com>
>> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
> 
> There isn't a query-network yet in QMP so libvirt is probably still 
> using the HMP version.
> 
> Can someone on the libvirt side Ack/Nack about whether this patch will 
> break libvirt?
> 

libvirt doesn't use 'info network'

- Cole