From: Gerd Hoffmann <kraxel@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/7] msi: Guard msi/msix_write_config with msi_present
Date: Wed, 08 Jun 2011 14:28:38 +0200 [thread overview]
Message-ID: <4DEF6AF6.6000805@redhat.com> (raw)
In-Reply-To: <0074e8926b2a8c93a8ef6aab9071d3e7e882a6c3.1307528800.git.jan.kiszka@siemens.com>
> @@ -1173,12 +1173,8 @@ static int intel_hda_exit(PCIDevice *pci)
> static void intel_hda_write_config(PCIDevice *pci, uint32_t addr,
> uint32_t val, int len)
> {
> - IntelHDAState *d = DO_UPCAST(IntelHDAState, pci, pci);
> -
> pci_default_write_config(pci, addr, val, len);
> - if (d->msi) {
> - msi_write_config(pci, addr, val, len);
> - }
> + msi_write_config(pci, addr, val, len);
> }
Nothing device specific left in there now. If msi_write_config() checks
itself whenever msi is enabled or not we could call it from
pci_default_write_config(), then zap this function altogether, no?
cheers,
Gerd
next prev parent reply other threads:[~2011-06-08 12:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 10:26 [Qemu-devel] [PATCH 0/7] msi: Small cleanups and fixes Jan Kiszka
2011-06-08 10:26 ` [Qemu-devel] [PATCH 1/7] msi: Fix copy&paste mistake in msi_uninit Jan Kiszka
2011-06-08 10:26 ` [Qemu-devel] [PATCH 2/7] msi: Guard msi/msix_write_config with msi_present Jan Kiszka
2011-06-08 12:28 ` Gerd Hoffmann [this message]
2011-06-08 12:33 ` Jan Kiszka
2011-06-08 14:32 ` Jan Kiszka
2011-06-08 10:26 ` [Qemu-devel] [PATCH 3/7] msi: Guard msi_reset " Jan Kiszka
2011-06-08 10:26 ` [Qemu-devel] [PATCH 4/7] msi: Use msi/msix_present more consistently Jan Kiszka
2011-06-08 10:26 ` [Qemu-devel] [PATCH 5/7] ahci/intel-hda: Properly reset MSI state Jan Kiszka
2011-06-08 10:53 ` Alexander Graf
2011-06-08 10:55 ` Jan Kiszka
2011-06-08 10:26 ` [Qemu-devel] [PATCH 6/7] msix: Align MSI-X constants to libpci definitions and extend them Jan Kiszka
2011-06-08 14:43 ` Isaku Yamahata
2011-06-08 14:46 ` Jan Kiszka
2011-06-08 20:14 ` Michael S. Tsirkin
2011-06-08 10:26 ` [Qemu-devel] [PATCH 7/7] msi: Move PCI_MSI_PENDING_32/64 into pci_regs.h Jan Kiszka
2011-06-08 10:46 ` [Qemu-devel] [PATCH 8/7] ivshmem: Reset MSI-X state on device reset Jan Kiszka
2011-06-08 20:15 ` [Qemu-devel] [PATCH 0/7] msi: Small cleanups and fixes Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEF6AF6.6000805@redhat.com \
--to=kraxel@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).