From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] inconsistency between device traversal in qdev and legacy
Date: Wed, 08 Jun 2011 19:00:40 +0200 [thread overview]
Message-ID: <4DEFAAB8.4090000@redhat.com> (raw)
In-Reply-To: <BANLkTinetbWq7xCVFHvYhL_kwc_-xuY+rg@mail.gmail.com>
Hi,
> Since qbus_create_inplace() adds each new child bus to
> the front of the parent's child_bus list, this means that
> qbus_find_recursive() will encounter the last-added bus
> first, whereas usb_bus_find() will get the first-added bus.
Quite a while back I've tried to switch qdev from QLIST to QTAILQ
exactly to allow adding stuff to the tail of the lists(s), because that
feels more natural to me than the current ordering. "info qtree" is
upside-down too ;)
Gave up after resending it one or two times, the forgot about it, wasn't
*that* important to me.
> Is there anything we can do to fix this inconsistency [*],
> or are we tied to the existing enumeration orders in both
> cases for compatibility with users with currently-working
> command lines or configurations?
Could be we break something. I think it is unlikely though. Multiple
busses of the same type are pretty uncommon, and any examples with
multiple lsi adapters (for example) advertise explicitly assign devices
via bus=. libvirt uses bus= everywhere too.
cheers,
Gerd
next prev parent reply other threads:[~2011-06-08 17:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 15:07 [Qemu-devel] inconsistency between device traversal in qdev and legacy Peter Maydell
2011-06-08 17:00 ` Gerd Hoffmann [this message]
2011-06-08 17:37 ` Andreas Färber
2011-06-08 17:39 ` Peter Maydell
2011-06-08 18:19 ` Rob Landley
2011-06-08 19:06 ` Andreas Färber
2011-06-09 13:59 ` Markus Armbruster
2011-06-09 14:12 ` Gerd Hoffmann
2011-06-09 14:32 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEFAAB8.4090000@redhat.com \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).