From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUMAG-0000p1-VX for qemu-devel@nongnu.org; Wed, 08 Jun 2011 13:03:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QUMAF-0002wW-JH for qemu-devel@nongnu.org; Wed, 08 Jun 2011 13:03:32 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:41917) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUMAF-0002wJ-AB for qemu-devel@nongnu.org; Wed, 08 Jun 2011 13:03:31 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e6.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p58GdJk1020731 for ; Wed, 8 Jun 2011 12:39:20 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p58H3SvY048952 for ; Wed, 8 Jun 2011 13:03:28 -0400 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p58B2lAv031902 for ; Wed, 8 Jun 2011 05:02:47 -0600 Message-ID: <4DEFAB48.9070205@linux.vnet.ibm.com> Date: Wed, 08 Jun 2011 12:03:04 -0500 From: Michael Roth MIME-Version: 1.0 References: <1307140399-9023-1-git-send-email-mdroth@linux.vnet.ibm.com> <20110608134346.59daaa8e@doriath> In-Reply-To: <20110608134346.59daaa8e@doriath> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [QAPI+QGA 2/3] QAPI code generation infrastructure v2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@linux.vnet.ibm.com, agl@linux.vnet.ibm.com, qemu-devel@nongnu.org, Jes.Sorensen@redhat.com On 06/08/2011 11:43 AM, Luiz Capitulino wrote: > On Fri, 3 Jun 2011 17:32:58 -0500 > Michael Roth wrote: > >> This is Set 2/3 of the QAPI+QGA patchsets. > > I have started taking a look at this series, but it turns out that this is > complex stuff and I'd like to spend time playing with it and testing it > throughly. > > I don't oppose merging this as is, as this series doesn't touch current QMP. > So I assume we'll have enough time to fix possible bugs before doing a mass > conversion. Yah, it's fairly well isolated from the rest of qemu. The error and json stuff (set1) was the only bit that would have an affect on qemu/qmp behavior, and that's been merged. > > The only problem is that all the patches have my signed off but I haven't > really reviewed them[*], so I'd feel more comfortable if they were removed > before merging (or that you wait for my review). > > * I guess that happened because Michael pulled from my repo and my git am > hook has the '-s' flag... Doh, yah the sign-offs were included in the commits I pulled. Sorry about that. To be clear though, are you referring to patches 1-3 of set1? I don't see your sign-off in any patches in this set.