From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUPci-0002sl-ND for qemu-devel@nongnu.org; Wed, 08 Jun 2011 16:45:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QUPcg-0007ve-9g for qemu-devel@nongnu.org; Wed, 08 Jun 2011 16:45:08 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:33794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUPcf-0007tW-Ne for qemu-devel@nongnu.org; Wed, 08 Jun 2011 16:45:06 -0400 Message-ID: <4DEFDF4A.1010501@web.de> Date: Wed, 08 Jun 2011 22:44:58 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20110608194845.GC30805@redhat.com> In-Reply-To: <20110608194845.GC30805@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig802892D16EB51985E517D49B" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH v2 9/9] msi: Move PCI_MSI_PENDING_32/64 into pci_regs.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig802892D16EB51985E517D49B Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-06-08 21:48, Michael S. Tsirkin wrote: > On Wed, Jun 08, 2011 at 06:21:52PM +0200, Jan Kiszka wrote: >> Signed-off-by: Jan Kiszka >=20 > pci_regs.h from linux does not have these > this is why we keep them in msi.c >=20 > [mst@tuck linux-2.6]$ grep PCI_MSI_ include/linux/pci_regs.h=20 > #define PCI_MSI_FLAGS 2 /* Various flags */ > #define PCI_MSI_FLAGS_64BIT 0x80 /* 64-bit addresses allowed */ > #define PCI_MSI_FLAGS_QSIZE 0x70 /* Message queue size configure= d > */ > #define PCI_MSI_FLAGS_QMASK 0x0e /* Maximum queue size available= > */ > #define PCI_MSI_FLAGS_ENABLE 0x01 /* MSI feature enabled */ > #define PCI_MSI_FLAGS_MASKBIT 0x100 /* 64-bit mask bits allowed */ > #define PCI_MSI_RFU 3 /* Rest of capability flags */ > #define PCI_MSI_ADDRESS_LO 4 /* Lower 32 bits */ > #define PCI_MSI_ADDRESS_HI 8 /* Upper 32 bits (if > PCI_MSI_FLAGS_64BIT set) */ > #define PCI_MSI_DATA_32 8 /* 16 bits of data for 32-bit > devices */ > #define PCI_MSI_MASK_32 12 /* Mask bits register for 32-bi= t > devices */ > #define PCI_MSI_DATA_64 12 /* 16 bits of data for 64-bit > devices */ > #define PCI_MSI_MASK_64 16 /* Mask bits register for 64-bi= t > devices */ >=20 >=20 > If you want to move them, please send them upstream we'll merge when > they are there. In fact, both defines are already in libpci. Since 3.0.0. Released 5 years ago. OK, I'll send a header resync patch against a more recent release. Then we should just lack something like PCI_MSIX_CTRL. I will have a look= =2E Jan --------------enig802892D16EB51985E517D49B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk3v304ACgkQitSsb3rl5xTengCbBP8VlsXTCB+6Pff6P1cIPjzk zPsAoLackEF6i5M/gHnK5/C9LtLd1Elv =2lRs -----END PGP SIGNATURE----- --------------enig802892D16EB51985E517D49B--