From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUPun-0007RP-Ks for qemu-devel@nongnu.org; Wed, 08 Jun 2011 17:03:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QUPul-0002Cq-Ks for qemu-devel@nongnu.org; Wed, 08 Jun 2011 17:03:49 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:51688) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUPul-0002Ck-4C for qemu-devel@nongnu.org; Wed, 08 Jun 2011 17:03:47 -0400 Message-ID: <4DEFE3AF.50302@web.de> Date: Wed, 08 Jun 2011 23:03:43 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20110608194845.GC30805@redhat.com> <4DEFDF4A.1010501@web.de> <20110608205622.GA32260@redhat.com> <4DEFE229.4030000@web.de> <20110608210148.GC32260@redhat.com> In-Reply-To: <20110608210148.GC32260@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigE1C24C10DE14F28D39421E32" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH v2 9/9] msi: Move PCI_MSI_PENDING_32/64 into pci_regs.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE1C24C10DE14F28D39421E32 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-06-08 23:01, Michael S. Tsirkin wrote: > On Wed, Jun 08, 2011 at 10:57:13PM +0200, Jan Kiszka wrote: >> On 2011-06-08 22:56, Michael S. Tsirkin wrote: >>> On Wed, Jun 08, 2011 at 10:44:58PM +0200, Jan Kiszka wrote: >>>> On 2011-06-08 21:48, Michael S. Tsirkin wrote: >>>>> On Wed, Jun 08, 2011 at 06:21:52PM +0200, Jan Kiszka wrote: >>>>>> Signed-off-by: Jan Kiszka >>>>> >>>>> pci_regs.h from linux does not have these >>>>> this is why we keep them in msi.c >>>>> >>>>> [mst@tuck linux-2.6]$ grep PCI_MSI_ include/linux/pci_regs.h=20 >>>>> #define PCI_MSI_FLAGS 2 /* Various flags */ >>>>> #define PCI_MSI_FLAGS_64BIT 0x80 /* 64-bit addresses allowed= */ >>>>> #define PCI_MSI_FLAGS_QSIZE 0x70 /* Message queue size confi= gured >>>>> */ >>>>> #define PCI_MSI_FLAGS_QMASK 0x0e /* Maximum queue size avail= able >>>>> */ >>>>> #define PCI_MSI_FLAGS_ENABLE 0x01 /* MSI feature enabled */ >>>>> #define PCI_MSI_FLAGS_MASKBIT 0x100 /* 64-bit mask bits allowed= */ >>>>> #define PCI_MSI_RFU 3 /* Rest of capability flags= */ >>>>> #define PCI_MSI_ADDRESS_LO 4 /* Lower 32 bits */ >>>>> #define PCI_MSI_ADDRESS_HI 8 /* Upper 32 bits (if >>>>> PCI_MSI_FLAGS_64BIT set) */ >>>>> #define PCI_MSI_DATA_32 8 /* 16 bits of data for 32-b= it >>>>> devices */ >>>>> #define PCI_MSI_MASK_32 12 /* Mask bits register for 3= 2-bit >>>>> devices */ >>>>> #define PCI_MSI_DATA_64 12 /* 16 bits of data for 64-b= it >>>>> devices */ >>>>> #define PCI_MSI_MASK_64 16 /* Mask bits register for 6= 4-bit >>>>> devices */ >>>>> >>>>> >>>>> If you want to move them, please send them upstream we'll merge whe= n >>>>> they are there. >>>> >>>> In fact, both defines are already in libpci. Since 3.0.0. Released 5= >>>> years ago. OK, I'll send a header resync patch against a more recent= >>>> release. >>>> >>>> Then we should just lack something like PCI_MSIX_CTRL. I will have a= look. >>> >>> PCI_MSIX_FLAGS is the same. >> >> That does not exist in libpci's header. >> >> Jan >> >=20 > The upstream I meant is pci_Regs.h in Linux. >=20 Why not sync against git://git.kernel.org/pub/scm/utils/pciutils/pciutils.git? Sounds more appropriate. Jan --------------enigE1C24C10DE14F28D39421E32 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk3v468ACgkQitSsb3rl5xSloACfdAtJ4ao29E0U2UIVYNmPDJZt bwwAoL+aUivhb79B8aJi8jVh1wZjHNHi =/Ur1 -----END PGP SIGNATURE----- --------------enigE1C24C10DE14F28D39421E32--